Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 03:37:06PM +0100, Ian Campbell wrote: > On Tue, 2015-09-29 at 22:01 +0800, Haozhong Zhang wrote: > > On Tue, Sep 29, 2015 at 02:56:12PM +0100, Andrew Cooper wrote: > > > On 29/09/15 14:53, Haozhong Zhang wrote: > > > > On Tue, Sep 29, 2015 at 11:28:38AM +0100, Ian Campbell w

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Ian Campbell
On Tue, 2015-09-29 at 22:01 +0800, Haozhong Zhang wrote: > On Tue, Sep 29, 2015 at 02:56:12PM +0100, Andrew Cooper wrote: > > On 29/09/15 14:53, Haozhong Zhang wrote: > > > On Tue, Sep 29, 2015 at 11:28:38AM +0100, Ian Campbell wrote: > > > > On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote:

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 02:56:12PM +0100, Andrew Cooper wrote: > On 29/09/15 14:53, Haozhong Zhang wrote: > > On Tue, Sep 29, 2015 at 11:28:38AM +0100, Ian Campbell wrote: > >> On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote: > >>> On 29/09/15 11:13, Haozhong Zhang wrote: > On Tue, Sep

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Andrew Cooper
On 29/09/15 14:53, Haozhong Zhang wrote: > On Tue, Sep 29, 2015 at 11:28:38AM +0100, Ian Campbell wrote: >> On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote: >>> On 29/09/15 11:13, Haozhong Zhang wrote: On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: > On Mon, 2015-09-2

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 11:28:38AM +0100, Ian Campbell wrote: > On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote: > > On 29/09/15 11:13, Haozhong Zhang wrote: > > > On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: > > > > On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: >

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 11:07:17AM +0100, Ian Campbell wrote: > On Tue, 2015-09-29 at 08:40 +0800, Haozhong Zhang wrote: > > > > @@ -1462,6 +1462,28 @@ static void parse_config_data(const char > > > > *config_source, > > > > } > > > > } > > > > > > > > +/* "vtsc_khz" option wor

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Wei Liu
On Tue, Sep 29, 2015 at 11:07:17AM +0100, Ian Campbell wrote: > On Tue, 2015-09-29 at 08:40 +0800, Haozhong Zhang wrote: > > > > @@ -1462,6 +1462,28 @@ static void parse_config_data(const char > > > > *config_source, > > > > } > > > > } > > > > > > > > +/* "vtsc_khz" option wor

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Andrew Cooper
On 29/09/15 11:28, Ian Campbell wrote: > On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote: >> On 29/09/15 11:13, Haozhong Zhang wrote: >>> On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: > This patch adds an optio

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Ian Campbell
On Tue, 2015-09-29 at 11:24 +0100, Andrew Cooper wrote: > On 29/09/15 11:13, Haozhong Zhang wrote: > > On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: > > > On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: > > > > This patch adds an option 'vtsc_khz' to allow users to set vcpu

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Julien Grall
On 29/09/15 10:50, Haozhong Zhang wrote: > On Tue, Sep 29, 2015 at 10:20:21AM +0100, Wei Liu wrote: >> On Tue, Sep 29, 2015 at 08:40:23AM +0800, Haozhong Zhang wrote: >>> On Mon, Sep 28, 2015 at 03:19:25PM +0100, Wei Liu wrote: On Mon, Sep 28, 2015 at 03:13:58PM +0800, Haozhong Zhang wrote: >>

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Andrew Cooper
On 29/09/15 11:13, Haozhong Zhang wrote: > On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: >> On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: >>> This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC >>> rate in KHz. In the case that tsc_mode = 'default', the

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 11:04:14AM +0100, Ian Campbell wrote: > On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: > > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > > rate in KHz. In the case that tsc_mode = 'default', the default value of > > 'vtsc_khz' option is th

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Ian Campbell
On Tue, 2015-09-29 at 08:40 +0800, Haozhong Zhang wrote: > > > @@ -1462,6 +1462,28 @@ static void parse_config_data(const char > > > *config_source, > > > } > > > } > > > > > > +/* "vtsc_khz" option works only if "tsc_mode" option is > > > + * "default". In this case, if "v

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Ian Campbell
On Mon, 2015-09-28 at 15:13 +0800, Haozhong Zhang wrote: > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > rate in KHz. In the case that tsc_mode = 'default', the default value of > 'vtsc_khz' option is the host TSC rate which is used when 'vtsc_khz' > option is set to 0 or

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Haozhong Zhang
On Tue, Sep 29, 2015 at 10:20:21AM +0100, Wei Liu wrote: > On Tue, Sep 29, 2015 at 08:40:23AM +0800, Haozhong Zhang wrote: > > On Mon, Sep 28, 2015 at 03:19:25PM +0100, Wei Liu wrote: > > > On Mon, Sep 28, 2015 at 03:13:58PM +0800, Haozhong Zhang wrote: > > > > This patch adds an option 'vtsc_khz'

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-29 Thread Wei Liu
On Tue, Sep 29, 2015 at 08:40:23AM +0800, Haozhong Zhang wrote: > On Mon, Sep 28, 2015 at 03:19:25PM +0100, Wei Liu wrote: > > On Mon, Sep 28, 2015 at 03:13:58PM +0800, Haozhong Zhang wrote: > > > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > > > rate in KHz. In the case t

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-28 Thread Haozhong Zhang
On Mon, Sep 28, 2015 at 03:19:25PM +0100, Wei Liu wrote: > On Mon, Sep 28, 2015 at 03:13:58PM +0800, Haozhong Zhang wrote: > > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > > rate in KHz. In the case that tsc_mode = 'default', the default value of > > 'vtsc_khz' option is

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-28 Thread Wei Liu
On Mon, Sep 28, 2015 at 03:13:58PM +0800, Haozhong Zhang wrote: > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > rate in KHz. In the case that tsc_mode = 'default', the default value of > 'vtsc_khz' option is the host TSC rate which is used when 'vtsc_khz' > option is set t

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-28 Thread Haozhong Zhang
Hi Julien, Thank you for the comments! On Mon, Sep 28, 2015 at 12:47:24PM +0100, Julien Grall wrote: > Hi, > > On 28/09/15 08:13, Haozhong Zhang wrote: > > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > > rate in KHz. In the case that tsc_mode = 'default', the default va

Re: [Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-28 Thread Julien Grall
Hi, On 28/09/15 08:13, Haozhong Zhang wrote: > This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC > rate in KHz. In the case that tsc_mode = 'default', the default value of > 'vtsc_khz' option is the host TSC rate which is used when 'vtsc_khz' > option is set to 0 or does not ap

[Xen-devel] [PATCH 13/13] tools/libxl: Add 'vtsc_khz' option to set guest TSC rate

2015-09-28 Thread Haozhong Zhang
This patch adds an option 'vtsc_khz' to allow users to set vcpu's TSC rate in KHz. In the case that tsc_mode = 'default', the default value of 'vtsc_khz' option is the host TSC rate which is used when 'vtsc_khz' option is set to 0 or does not appear in the configuration. In all other cases of tsc_m