Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-26 Thread Stefano Stabellini
On Wed, 20 Jul 2016, Julien Grall wrote: > The p2m root table does not need to be allocate separately. > > Also remove unnecessary fields initialization as the structure is already > memset to 0 and the fields will be override by p2m_alloc_table. ^ overridden

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-23 Thread Sergej Proskurin
Hi Julien, > > This patch moved p2m_alloc_table call into p2m_init (i.e your > p2m_init_one). You complained that the function was not exported > anymore, but you did not look how it was called in this patch. > Ok. At this point our patches indeed derailed too much from each other. We should co

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Julien Grall
On 22/07/16 12:05, Sergej Proskurin wrote: On 07/22/2016 12:38 PM, Julien Grall wrote: On 22/07/16 11:39, Sergej Proskurin wrote: On 07/22/2016 12:26 PM, Julien Grall wrote: On 22/07/16 11:16, Sergej Proskurin wrote: Hi Julien, Hello, On 07/22/2016 11:18 AM, Julien Grall wrote:

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Sergej Proskurin
On 07/22/2016 12:38 PM, Julien Grall wrote: > > > On 22/07/16 11:39, Sergej Proskurin wrote: >> >> >> On 07/22/2016 12:26 PM, Julien Grall wrote: >>> >>> >>> On 22/07/16 11:16, Sergej Proskurin wrote: Hi Julien, >>> >>> Hello, >>> On 07/22/2016 11:18 AM, Julien Grall wrote: >

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Julien Grall
On 22/07/16 11:39, Sergej Proskurin wrote: On 07/22/2016 12:26 PM, Julien Grall wrote: On 22/07/16 11:16, Sergej Proskurin wrote: Hi Julien, Hello, On 07/22/2016 11:18 AM, Julien Grall wrote: On 22/07/16 09:32, Sergej Proskurin wrote: Hi Julien, Hello Sergej, -int p2m_alloc_ta

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Sergej Proskurin
On 07/22/2016 12:26 PM, Julien Grall wrote: > > > On 22/07/16 11:16, Sergej Proskurin wrote: >> Hi Julien, > > Hello, > >> On 07/22/2016 11:18 AM, Julien Grall wrote: >>> >>> >>> On 22/07/16 09:32, Sergej Proskurin wrote: Hi Julien, >>> >>> Hello Sergej, >>> > -int p2m_alloc_table(st

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Julien Grall
On 22/07/16 11:16, Sergej Proskurin wrote: Hi Julien, Hello, On 07/22/2016 11:18 AM, Julien Grall wrote: On 22/07/16 09:32, Sergej Proskurin wrote: Hi Julien, Hello Sergej, -int p2m_alloc_table(struct domain *d) +static int p2m_alloc_table(struct domain *d) While moving parts of t

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Sergej Proskurin
Hi Julien, On 07/22/2016 11:18 AM, Julien Grall wrote: > > > On 22/07/16 09:32, Sergej Proskurin wrote: >> Hi Julien, > > Hello Sergej, > >>> -int p2m_alloc_table(struct domain *d) >>> +static int p2m_alloc_table(struct domain *d) >> >> While moving parts of the altp2m code out of ./xen/arch/a

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Julien Grall
On 22/07/16 09:32, Sergej Proskurin wrote: Hi Julien, Hello Sergej, -int p2m_alloc_table(struct domain *d) +static int p2m_alloc_table(struct domain *d) While moving parts of the altp2m code out of ./xen/arch/arm/p2m.c, the function p2m_alloc_table needs to be called from ./xen/arch/arm/a

Re: [Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-22 Thread Sergej Proskurin
Hi Julien, > -int p2m_alloc_table(struct domain *d) > +static int p2m_alloc_table(struct domain *d) While moving parts of the altp2m code out of ./xen/arch/arm/p2m.c, the function p2m_alloc_table needs to be called from ./xen/arch/arm/altp2m.c to allocate the individual altp2m views. Hence it sh

[Xen-devel] [PATCH 15/22] xen/arm: Don't call p2m_alloc_table from arch_domain_create

2016-07-20 Thread Julien Grall
The p2m root table does not need to be allocate separately. Also remove unnecessary fields initialization as the structure is already memset to 0 and the fields will be override by p2m_alloc_table. Signed-off-by: Julien Grall --- xen/arch/arm/domain.c | 3 --- xen/arch/arm/p2m.c| 8