Re: [Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-06-03 Thread Juergen Gross
On 03/06/17 09:04, Nicholas A. Bellinger wrote: > On Fri, 2017-06-02 at 22:40 -0700, Nicholas A. Bellinger wrote: >> On Tue, 2017-05-23 at 16:48 -0700, Bart Van Assche wrote: >>> scsiback_release_cmd() must not dereference se_cmd->se_tmr_req >>> because that memory is freed by

Re: [Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-06-03 Thread Nicholas A. Bellinger
On Fri, 2017-06-02 at 22:40 -0700, Nicholas A. Bellinger wrote: > On Tue, 2017-05-23 at 16:48 -0700, Bart Van Assche wrote: > > scsiback_release_cmd() must not dereference se_cmd->se_tmr_req > > because that memory is freed by target_free_cmd_mem() before > > scsiback_release_cmd() is called. Fix

Re: [Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-06-02 Thread Nicholas A. Bellinger
On Tue, 2017-05-23 at 16:48 -0700, Bart Van Assche wrote: > scsiback_release_cmd() must not dereference se_cmd->se_tmr_req > because that memory is freed by target_free_cmd_mem() before > scsiback_release_cmd() is called. Fix this use-after-free by > inlining struct scsiback_tmr into struct

Re: [Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-05-26 Thread Juergen Gross
On 24/05/17 01:48, Bart Van Assche wrote: > scsiback_release_cmd() must not dereference se_cmd->se_tmr_req > because that memory is freed by target_free_cmd_mem() before > scsiback_release_cmd() is called. Fix this use-after-free by > inlining struct scsiback_tmr into struct vscsibk_pend. > >

[Xen-devel] [PATCH 15/33] xen/scsiback: Fix a use-after-free

2017-05-23 Thread Bart Van Assche
scsiback_release_cmd() must not dereference se_cmd->se_tmr_req because that memory is freed by target_free_cmd_mem() before scsiback_release_cmd() is called. Fix this use-after-free by inlining struct scsiback_tmr into struct vscsibk_pend. Signed-off-by: Bart Van Assche