Re: [Xen-devel] [PATCH 2/2] CODING_STYLE: Forbid nested block in the hypervisor code

2017-07-04 Thread Julien Grall
Hi, On 07/04/2017 03:17 PM, Andrew Cooper wrote: On 04/07/17 13:20, Jan Beulich wrote: On 04.07.17 at 14:12, wrote: When removing if/for/while statements, the code should be reworked to remove the { } and the extra indentation. Yes. This is improving code

Re: [Xen-devel] [PATCH 2/2] CODING_STYLE: Forbid nested block in the hypervisor code

2017-07-04 Thread Andrew Cooper
On 04/07/17 13:20, Jan Beulich wrote: On 04.07.17 at 14:12, wrote: >> When removing if/for/while statements, the code should be reworked to >> remove the { } and the extra indentation. > Yes. > >> This is improving code maintainability and code readability. > For the

Re: [Xen-devel] [PATCH 2/2] CODING_STYLE: Forbid nested block in the hypervisor code

2017-07-04 Thread Jan Beulich
>>> On 04.07.17 at 14:12, wrote: > When removing if/for/while statements, the code should be reworked to > remove the { } and the extra indentation. Yes. > This is improving code maintainability and code readability. For the given example, yes. However, there are (rare)

[Xen-devel] [PATCH 2/2] CODING_STYLE: Forbid nested block in the hypervisor code

2017-07-04 Thread Julien Grall
When removing if/for/while statements, the code should be reworked to remove the { } and the extra indentation. This is improving code maintainability and code readability. Signed-off-by: Julien Grall --- This patch was triggered whilst reviewing a patch [1] on ARM