Re: [Xen-devel] [PATCH 2/2] x86/pv: Align %rsp before pushing the failsafe stack frame

2017-05-08 Thread Andrew Cooper
On 08/05/17 11:56, Jan Beulich wrote: On 08.05.17 at 12:04, wrote: >> Architecturally, all 64bit stacks are aligned on a 16 byte boundary before an >> exception frame is pushed. The failsafe frame is not special in this regard. > I'd prefer "should not be" as effectively is has been so far,

Re: [Xen-devel] [PATCH 2/2] x86/pv: Align %rsp before pushing the failsafe stack frame

2017-05-08 Thread Jan Beulich
>>> On 08.05.17 at 12:04, wrote: > Architecturally, all 64bit stacks are aligned on a 16 byte boundary before an > exception frame is pushed. The failsafe frame is not special in this regard. I'd prefer "should not be" as effectively is has been so far, but other than that ... > Signed-off-by:

[Xen-devel] [PATCH 2/2] x86/pv: Align %rsp before pushing the failsafe stack frame

2017-05-08 Thread Andrew Cooper
Architecturally, all 64bit stacks are aligned on a 16 byte boundary before an exception frame is pushed. The failsafe frame is not special in this regard. Signed-off-by: Andrew Cooper --- CC: Jan Beulich CC: Julien Grall This change should be backported to all releases, and included in Xen 4.