Re: [Xen-devel] [PATCH 2/2] xen: arm: Set all bits in mfn_to_xen_entry()

Hi Chris, On 14/08/2015 14:42, Chris (Christopher) Brand wrote: Ensure that every bit has a specific value. Reported-by: Julien Grall julien.gr...@citrix.com Signed-off-by: Chris Brand chris.br...@broadcom.com --- xen/include/asm-arm/page.h | 5 + 1 file changed, 5 insertions(+) diff

Re: [Xen-devel] [PATCH 2/2] xen: arm: Set all bits in mfn_to_xen_entry()

On 17/08/2015 11:58, Chris (Christopher) Brand wrote: Hi Julien, Thanks for the review. +.pxn = 0, I would add a comment to explain that this bit is reserved for PL2 stage 1 page table. Will do. +.avail = 0, I don't think this one is necessary. avail is not

Re: [Xen-devel] [PATCH 2/2] xen: arm: Set all bits in mfn_to_xen_entry()

Hi Julien, Thanks for the review. +.pxn = 0, I would add a comment to explain that this bit is reserved for PL2 stage 1 page table. Will do. +.avail = 0, I don't think this one is necessary. avail is not used by the hardware neither Xen. grep -rF pt.avail

[Xen-devel] [PATCH 2/2] xen: arm: Set all bits in mfn_to_xen_entry()

Ensure that every bit has a specific value. Reported-by: Julien Grall julien.gr...@citrix.com Signed-off-by: Chris Brand chris.br...@broadcom.com --- xen/include/asm-arm/page.h | 5 + 1 file changed, 5 insertions(+) diff --git a/xen/include/asm-arm/page.h b/xen/include/asm-arm/page.h index