Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-05 Thread Paul Durrant
t; Ian > Jackson; xen-de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control > ring and toeplitz hashing > > > > You've put the consumer values into the shared page. I'd rather not have > > > to scrut

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread Konrad Rzeszutek Wilk
> > You've put the consumer values into the shared page. I'd rather not have > > to scrutinize your shared ring implementation for other security bugs. > > Similarly, if there's another security issues like XSA-155 I'd rather > > not have to look at another non-standard shared ring implementation.

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread Paul Durrant
nt; xen-de...@lists.xenproject.org > >> Cc: Tim (Xen.org); Keir (Xen.org); Ian Campbell; Jan Beulich; Ian Jackson > >> Subject: Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control > >> ring and toeplitz hashing > >> > >> On 04/01/16 11:14, Paul Durr

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread David Vrabel
ch; Ian Jackson >> Subject: Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control >> ring and toeplitz hashing >> >> On 04/01/16 11:14, Paul Durrant wrote: >>>>>> You should use the standard ring format and infrastructure. >>>>> &g

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread Paul Durrant
> -Original Message- > From: David Vrabel [mailto:david.vra...@citrix.com] > Sent: 04 January 2016 11:18 > To: Paul Durrant; xen-de...@lists.xenproject.org > Cc: Tim (Xen.org); Keir (Xen.org); Ian Campbell; Jan Beulich; Ian Jackson > Subject: Re: [Xen-devel] [PATCH 2/3]

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread David Vrabel
On 04/01/16 11:14, Paul Durrant wrote: You should use the standard ring format and infrastructure. >>> >>> Is there one for variable message size rings? I didn't find one. I >>> don't want to use the fixed size balanced ring macros for control >>> messages as fixed size messages really aren't

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread Paul Durrant
-devel] [PATCH 2/3] public/io/netif.h: document control > ring and toeplitz hashing > > On 04/01/16 09:37, Paul Durrant wrote: > >>> + * The layout of the shared page is as follows: > >>> + * > >>

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread David Vrabel
On 04/01/16 09:37, Paul Durrant wrote: >>> + * The layout of the shared page is as follows: >>> + * >>> + *0 1 2 3 4 5 6 7 octet >>> + * +-+-+-+-+-+-+-+-+ >>> + * |req_cons |req_prod | >>> + * +-+-+

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2016-01-04 Thread Paul Durrant
> -Original Message- > From: David Vrabel [mailto:david.vra...@citrix.com] > Sent: 23 December 2015 13:28 > To: Paul Durrant; xen-de...@lists.xenproject.org > Cc: Keir (Xen.org); Ian Campbell; Tim (Xen.org); Ian Jackson; Jan Beulich > Subject: Re: [Xen-devel] [PATCH 2/3]

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2015-12-23 Thread David Vrabel
On 23/12/15 10:06, Paul Durrant wrote: > This patch documents a new shared (variable message length) ring between > frontend and backend that can be used to pass bulk out-of-band data, such > as that required to implement toeplitz hashing in the backend that is > configurable by the frontend. > >

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2015-12-23 Thread Paul Durrant
bject: Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control > ring and toeplitz hashing > > On 23/12/2015 10:06, Paul Durrant wrote: > > +#define NETIF_CTRL_RING_SIZE 1024 > > + > > +struct netif_ctrl_ring { > > + RING_IDX req_cons; > > + RI

Re: [Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2015-12-23 Thread Andrew Cooper
On 23/12/2015 10:06, Paul Durrant wrote: > +#define NETIF_CTRL_RING_SIZE 1024 > + > +struct netif_ctrl_ring { > + RING_IDX req_cons; > + RING_IDX req_prod; > + RING_IDX rsp_cons; > + RING_IDX rsp_prod; > + uint8_t req[NETIF_CTRL_RING_SIZE]; > + uint8_t rsp[NETIF_CTRL_RING_SI

[Xen-devel] [PATCH 2/3] public/io/netif.h: document control ring and toeplitz hashing

2015-12-23 Thread Paul Durrant
This patch documents a new shared (variable message length) ring between frontend and backend that can be used to pass bulk out-of-band data, such as that required to implement toeplitz hashing in the backend that is configurable by the frontend. The patch then goes on to document the messages pas