[Xen-devel] [PATCH 2/3] x86/vmx: Don't self-recurse in vmx_update_guest_cr()

2017-09-29 Thread Andrew Cooper
An update to CR4 following a CR0 update can be done easily by falling through into the CR4 case. This avoids unnecessary passes through vmx_vmcs_{enter,exit}() and unnecessary stack usage (as the compiler cannot optimise this use to a tailcall). Signed-off-by: Andrew Cooper --- CC: Jan Beulich

Re: [Xen-devel] [PATCH 2/3] x86/vmx: Don't self-recurse in vmx_update_guest_cr()

2017-10-03 Thread Roger Pau Monné
On Fri, Sep 29, 2017 at 06:31:02PM +, Andrew Cooper wrote: > An update to CR4 following a CR0 update can be done easily by falling > through into the CR4 case. This avoids unnecessary passes through > vmx_vmcs_{enter,exit}() and unnecessary stack usage (as the compiler > cannot optimise this u

Re: [Xen-devel] [PATCH 2/3] x86/vmx: Don't self-recurse in vmx_update_guest_cr()

2017-10-09 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Saturday, September 30, 2017 2:31 AM > > An update to CR4 following a CR0 update can be done easily by falling > through into the CR4 case. This avoids unnecessary passes through > vmx_vmcs_{enter,exit}() and unnecessary stack usage