Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-18 Thread Konrad Rzeszutek Wilk
On Tue, Jul 18, 2017 at 02:38:14PM +0100, Wei Liu wrote: > On Fri, Jul 07, 2017 at 10:00:01AM -0400, Konrad Rzeszutek Wilk wrote: > > > > > > 1. PV PCI passthrough is done via pciback, which means the physical > > >device is assigned to the driver domain. All events to / from the > > >

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-18 Thread Wei Liu
On Fri, Jul 07, 2017 at 10:00:01AM -0400, Konrad Rzeszutek Wilk wrote: > > > > 1. PV PCI passthrough is done via pciback, which means the physical > >device is assigned to the driver domain. All events to / from the > >guest / device are handled by the driver domain -- which includes > >

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-07 Thread Konrad Rzeszutek Wilk
On Fri, Jul 07, 2017 at 11:56:43AM +0100, Wei Liu wrote: > On Wed, Jul 05, 2017 at 02:52:41PM -0500, Venu Busireddy wrote: > > > [...] > > > > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c > > > > index 89c2b25..10a48a9 100644 > > > > --- a/tools/xl/xl_vmcontrol.c > > > > +++

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-07 Thread Wei Liu
On Wed, Jul 05, 2017 at 02:52:41PM -0500, Venu Busireddy wrote: > > [...] > > > diff --git a/tools/xl/xl_vmcontrol.c b/tools/xl/xl_vmcontrol.c > > > index 89c2b25..10a48a9 100644 > > > --- a/tools/xl/xl_vmcontrol.c > > > +++ b/tools/xl/xl_vmcontrol.c > > > @@ -966,6 +966,15 @@ start: > > >

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-07-05 Thread Venu Busireddy
On 2017-06-30 11:18:10 +0100, Wei Liu wrote: > I haven't reviewed the code in detail, but I have some questions > regarding the design. See the end of this email. > > On Tue, Jun 27, 2017 at 12:14:54PM -0500, Venu Busireddy wrote: > > > > +static void pciassignable_list_hidden(void) > > +{ > >

Re: [Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-06-30 Thread Wei Liu
I haven't reviewed the code in detail, but I have some questions regarding the design. See the end of this email. On Tue, Jun 27, 2017 at 12:14:54PM -0500, Venu Busireddy wrote: > > +static void pciassignable_list_hidden(void) > +{ > +libxl_device_pci *pcidevs; > +int num, i; > + > +

[Xen-devel] [PATCH 2/6] xl: Add commands for hiding and unhiding pcie passthrough devices

2017-06-27 Thread Venu Busireddy
xl: Add commands for hiding and unhiding pcie passthrough devices Introduce three subcommands: 'xl pci-assignable-hide ' to hide a device, 'xl pci-assignable-unhide ' to unhide a previously hidden device, and 'xl pci-assignable-list-hidden' to list the hidden devices. Changed create_domain() to