Re: [Xen-devel] [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page is present

2017-03-20 Thread Jan Beulich
>>> On 20.03.17 at 14:42, wrote: >> From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Paul >> Durrant >> Sent: 20 March 2017 11:50 >> > From: Jan Beulich [mailto:jbeul...@suse.com] >> > Sent: 20 March 2017 11:36 >> > >>> On 17.03.17 at 10:57, wrote: >> > > --- a/xen/include/a

Re: [Xen-devel] [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page is present

2017-03-20 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Paul Durrant > Sent: 20 March 2017 11:50 > To: 'Jan Beulich' > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: Re: [Xen-devel] [PATCH 2/7] x

Re: [Xen-devel] [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page is present

2017-03-20 Thread Paul Durrant
> -Original Message- > From: Jan Beulich [mailto:jbeul...@suse.com] > Sent: 20 March 2017 11:36 > To: Paul Durrant > Cc: Andrew Cooper ; xen- > de...@lists.xenproject.org > Subject: Re: [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page > is present > > >>> On 17.03.17 at 10:5

Re: [Xen-devel] [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page is present

2017-03-20 Thread Jan Beulich
>>> On 17.03.17 at 10:57, wrote: > @@ -288,6 +304,14 @@ static void initialize_vp_assist(struct vcpu *v) > * enlightenment. > */ > > +if ( v->arch.hvm_vcpu.viridian.vp_assist.va ) > +{ > +if ( v->arch.hvm_vcpu.viridian.vp_assist.gmfn == gmfn ) > +return;

[Xen-devel] [PATCH 2/7] x86/viridian: fix xen-hvmcrash when vp_assist page is present

2017-03-17 Thread Paul Durrant
Currently use of xen-hvmcrash will cause an immediate domain_crash() in initialize_vp_assist() because it is called from viridian_load_vcpu_ctxt() without having first cleared any previous mapping. This patch makes initialize_vp_assist() responsible for clearing previous mappings, if necessary. S