Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-09 Thread Jan Beulich
>>> On 08.02.16 at 17:57, wrote: > This patch merges almost identical functions hvm_event_int3 > and hvm_event_single_step into a single function called > hvm_event_software_breakpoint. Except that "software breakpoint" is rather questionable a name here, considering that

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-09 Thread Corneliu ZUZU
On 2/9/2016 1:19 PM, Jan Beulich wrote: On 08.02.16 at 17:57, wrote: This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single function called hvm_event_software_breakpoint. Except that "software breakpoint" is rather

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-09 Thread Jan Beulich
>>> On 09.02.16 at 12:52, wrote: > On 2/9/2016 1:19 PM, Jan Beulich wrote: > On 08.02.16 at 17:57, wrote: >>> This patch merges almost identical functions hvm_event_int3 >>> and hvm_event_single_step into a single function called >>>

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-09 Thread Corneliu ZUZU
On 2/9/2016 2:12 PM, Jan Beulich wrote: On 09.02.16 at 12:52, wrote: On 2/9/2016 1:19 PM, Jan Beulich wrote: On 08.02.16 at 17:57, wrote: This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single

[Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
This patch merges almost identical functions hvm_event_int3 and hvm_event_single_step into a single function called hvm_event_software_breakpoint. Signed-off-by: Corneliu ZUZU --- xen/arch/x86/hvm/event.c| 52 ++---

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 8:17 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 10:49 AM, Corneliu ZUZU > wrote: On 2/8/2016 7:15 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: diff --git

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 10:15 AM, Andrew Cooper wrote: > On 08/02/16 16:57, Corneliu ZUZU wrote: > > diff --git a/xen/include/asm-x86/hvm/event.h > b/xen/include/asm-x86/hvm/event.h > > index 11eb1fe..7c2252b 100644 > > --- a/xen/include/asm-x86/hvm/event.h > > +++

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Corneliu ZUZU
On 2/8/2016 7:15 PM, Andrew Cooper wrote: On 08/02/16 16:57, Corneliu ZUZU wrote: diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h index 11eb1fe..7c2252b 100644 --- a/xen/include/asm-x86/hvm/event.h +++ b/xen/include/asm-x86/hvm/event.h @@ -27,9 +27,8 @@ bool_t

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Andrew Cooper
On 08/02/16 16:57, Corneliu ZUZU wrote: > diff --git a/xen/include/asm-x86/hvm/event.h b/xen/include/asm-x86/hvm/event.h > index 11eb1fe..7c2252b 100644 > --- a/xen/include/asm-x86/hvm/event.h > +++ b/xen/include/asm-x86/hvm/event.h > @@ -27,9 +27,8 @@ bool_t hvm_event_cr(unsigned int index,

Re: [Xen-devel] [PATCH 2/7] x86: hvm events: merge 2 functions into 1

2016-02-08 Thread Tamas K Lengyel
On Mon, Feb 8, 2016 at 10:49 AM, Corneliu ZUZU wrote: > On 2/8/2016 7:15 PM, Andrew Cooper wrote: > >> On 08/02/16 16:57, Corneliu ZUZU wrote: >> >>> diff --git a/xen/include/asm-x86/hvm/event.h >>> b/xen/include/asm-x86/hvm/event.h >>> index 11eb1fe..7c2252b 100644 >>>