Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-25 Thread Stefano Stabellini
Hi Bhupinder, Thanks for trying, and I would have done the same thing as you did: ifeq ($(CONFIG_SBSA_VUART_CONSOLE),y) CONFIG_VUART_CONSOLE := y endif However, we don't want to introduce a dependency between "make tools" and "make xen", meaning that one should be able to do "make tools"

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-25 Thread Stefano Stabellini
On Tue, 25 Jul 2017, Julien Grall wrote: > Hi Stefano, > > On 07/21/2017 08:44 PM, Stefano Stabellini wrote: > > On Fri, 21 Jul 2017, Julien Grall wrote: > > > Hi, > > > > > > On 18/07/17 21:07, Stefano Stabellini wrote: > > > > On Mon, 17 Jul 2017, Bhupinder Thakur wrote: > > > > > This patch

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-25 Thread Julien Grall
Hi Stefano, On 07/21/2017 08:44 PM, Stefano Stabellini wrote: On Fri, 21 Jul 2017, Julien Grall wrote: Hi, On 18/07/17 21:07, Stefano Stabellini wrote: On Mon, 17 Jul 2017, Bhupinder Thakur wrote: This patch finally adds the support for vuart console. It adds two new fields in the console

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-25 Thread Bhupinder Thakur
Hi Stefano, Can we make CONFIG_VUART_CONSOLE dependent on CONFIG_SBSA_VUART_CONSOLE? CONFIG_SBSA_VUART_CONSOLE is a Kconfig option while CONFIG_VUART_CONSOLE is an option defined in the .mk file which is used while compiling the toolstack. So if I try to do something like this in

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-21 Thread Stefano Stabellini
On Fri, 21 Jul 2017, Julien Grall wrote: > Hi, > > On 18/07/17 21:07, Stefano Stabellini wrote: > > On Mon, 17 Jul 2017, Bhupinder Thakur wrote: > > > This patch finally adds the support for vuart console. It adds > > > two new fields in the console initialization: > > > > > > - optional > > > -

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-21 Thread Julien Grall
Hi, On 18/07/17 21:07, Stefano Stabellini wrote: On Mon, 17 Jul 2017, Bhupinder Thakur wrote: This patch finally adds the support for vuart console. It adds two new fields in the console initialization: - optional - prefer_gnttab optional flag tells whether the console is optional.

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-21 Thread Bhupinder Thakur
Hi Stefano, >> CONFIG_ARM := y >> CONFIG_ARM_32 := y >> +CONFIG_VUART_CONSOLE := y >> CONFIG_ARM_$(XEN_OS) := y >> >> CONFIG_XEN_INSTALL_SUFFIX := > > What about leaving this off for ARM32 by default? I will disable it for ARM32. >> - if (!con->interface && xgt_handle) { >> + if

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-18 Thread Stefano Stabellini
On Mon, 17 Jul 2017, Bhupinder Thakur wrote: > This patch finally adds the support for vuart console. It adds > two new fields in the console initialization: > > - optional > - prefer_gnttab > > optional flag tells whether the console is optional. > > prefer_gnttab tells whether the ring buffer

Re: [Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-18 Thread Wei Liu
On Mon, Jul 17, 2017 at 06:36:52PM +0530, Bhupinder Thakur wrote: > This patch finally adds the support for vuart console. It adds > two new fields in the console initialization: > > - optional > - prefer_gnttab > > optional flag tells whether the console is optional. > > prefer_gnttab tells

[Xen-devel] [PATCH 22/25 v6] xen/arm: vpl011: Add support for vuart console in xenconsole

2017-07-17 Thread Bhupinder Thakur
This patch finally adds the support for vuart console. It adds two new fields in the console initialization: - optional - prefer_gnttab optional flag tells whether the console is optional. prefer_gnttab tells whether the ring buffer should be allocated using grant table. Signed-off-by: