Sorry for the late reply.
On Thu, Feb 26, 2015 at 04:49:21PM -0700, Jim Fehlig wrote:
> Wei Liu wrote:
> > On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote:
> >
> >> At minimum, libvirt will populate the pdev_path, vdev, backend, and
> >> format fields. If backend and format (which, i
Wei Liu wrote:
> On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote:
>
>> At minimum, libvirt will populate the pdev_path, vdev, backend, and
>> format fields. If backend and format (which, in libvirt-speack
>> correspond to the 'name' and 'type' attributes on the optional
>> element) a
On Wed, Feb 11, 2015 at 10:18:18AM -0700, Jim Fehlig wrote:
> Wei Liu wrote:
> > On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote:
> >
> >> Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should
> >> retrieve backend from xenstore"):
> >>
> >>> ... if backend is not
Jim Fehlig writes ("Re: [PATCH 3/3] libxl: libxl__device_from_disk should
retrieve backend from xenstore"):
> Wei Liu wrote:
> > On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote:
> >> What should happen if the caller specifies a different target in disk
> >> to the one the device is act
Wei Liu wrote:
> On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote:
>
>> Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should retrieve
>> backend from xenstore"):
>>
>>> ... if backend is not set by caller.
>>>
>> Acked-by: Ian Jackson
>>
>> as far as it goe
On Tue, Feb 10, 2015 at 11:01:46AM +, Ian Jackson wrote:
> Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should retrieve
> backend from xenstore"):
> > ... if backend is not set by caller.
>
> Acked-by: Ian Jackson
>
> as far as it goes, but I think you may want a more radical
Wei Liu writes ("[PATCH 3/3] libxl: libxl__device_from_disk should retrieve
backend from xenstore"):
> ... if backend is not set by caller.
Acked-by: Ian Jackson
as far as it goes, but I think you may want a more radical change -
see below.
> Also change the function to use "goto" idiom while
... if backend is not set by caller.
Also change the function to use "goto" idiom while I was there.
Signed-off-by: Wei Liu
Cc: Ian Campbell
Cc: Ian Jackson
---
tools/libxl/libxl.c | 21 ++---
1 file changed, 18 insertions(+), 3 deletions(-)
diff --git a/tools/libxl/libxl.c b
