Re: [Xen-devel] [PATCH 3/3] x86: tighten MMU_*PT_UPDATE* check and combine error paths

2017-10-12 Thread Jan Beulich
>>> On 12.10.17 at 13:31, wrote: > On 12/10/17 11:01, Jan Beulich wrote: >> Don't accept anything other than r/w RAM pages and move the paged-out >> check into the (unlikely) error path following that check. >> >> Signed-off-by: Jan Beulich > > How does dom0 boot with this change in place? You

Re: [Xen-devel] [PATCH 3/3] x86: tighten MMU_*PT_UPDATE* check and combine error paths

2017-10-12 Thread Andrew Cooper
On 12/10/17 11:01, Jan Beulich wrote: > Don't accept anything other than r/w RAM pages and move the paged-out > check into the (unlikely) error path following that check. > > Signed-off-by: Jan Beulich How does dom0 boot with this change in place?  You appear to have prohibited mapping MMIO frame

[Xen-devel] [PATCH 3/3] x86: tighten MMU_*PT_UPDATE* check and combine error paths

2017-10-12 Thread Jan Beulich
Don't accept anything other than r/w RAM pages and move the paged-out check into the (unlikely) error path following that check. Signed-off-by: Jan Beulich --- a/xen/arch/x86/mm.c +++ b/xen/arch/x86/mm.c @@ -3507,18 +3507,18 @@ long do_mmu_update( gmfn = req.ptr >> PAGE_SHIFT;