Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:51:05PM +0200, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Wei Liu wrote: > > On Fri, Apr 08, 2016 at 04:35:22PM +0200, Roger Pau Monné wrote: > > > On Fri, 8 Apr 2016, Wei Liu wrote: > > > > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > > > > > On F

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread George Dunlap
On Fri, Apr 8, 2016 at 3:59 PM, Andrew Cooper wrote: > On 08/04/16 15:51, Roger Pau Monné wrote: >> On Fri, 8 Apr 2016, Wei Liu wrote: >>> On Fri, Apr 08, 2016 at 04:35:22PM +0200, Roger Pau Monné wrote: On Fri, 8 Apr 2016, Wei Liu wrote: > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Andrew Cooper
On 08/04/16 15:51, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Wei Liu wrote: >> On Fri, Apr 08, 2016 at 04:35:22PM +0200, Roger Pau Monné wrote: >>> On Fri, 8 Apr 2016, Wei Liu wrote: On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Wei Liu wrote: >>

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Roger Pau Monné
On Fri, 8 Apr 2016, Wei Liu wrote: > On Fri, Apr 08, 2016 at 04:35:22PM +0200, Roger Pau Monné wrote: > > On Fri, 8 Apr 2016, Wei Liu wrote: > > > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > > > > On Fri, 8 Apr 2016, Wei Liu wrote: > > > > > On Thu, Apr 07, 2016 at 07:45:28PM

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:35:22PM +0200, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Wei Liu wrote: > > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > > > On Fri, 8 Apr 2016, Wei Liu wrote: > > > > On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > > > > > Sign

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Roger Pau Monné
On Fri, 8 Apr 2016, Wei Liu wrote: > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > > On Fri, 8 Apr 2016, Wei Liu wrote: > > > On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > > > > Signed-off-by: Roger Pau Monné > > > > Cc: Ian Jackson > > > > Cc: Wei Liu >

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Ian Jackson
Wei Liu writes ("Re: [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}"): > On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > > It's specific to guests with a device model (those are the only ones that > > can have an emulated CDROM device), and th

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Wei Liu
On Fri, Apr 08, 2016 at 04:17:55PM +0200, Roger Pau Monné wrote: > On Fri, 8 Apr 2016, Wei Liu wrote: > > On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > > > Signed-off-by: Roger Pau Monné > > > Cc: Ian Jackson > > > Cc: Wei Liu > > > --- > > > tools/libxl/libxl.c | 6 ++

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Roger Pau Monné
On Fri, 8 Apr 2016, Wei Liu wrote: > On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > > Signed-off-by: Roger Pau Monné > > Cc: Ian Jackson > > Cc: Wei Liu > > --- > > tools/libxl/libxl.c | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/tools/libxl/libxl.c

Re: [Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-08 Thread Wei Liu
On Thu, Apr 07, 2016 at 07:45:28PM +0200, Roger Pau Monne wrote: > Signed-off-by: Roger Pau Monné > Cc: Ian Jackson > Cc: Wei Liu > --- > tools/libxl/libxl.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c > index 9d785a4..232e2c1 100644

[Xen-devel] [PATCH 3/4] libxl: only allow guests with a device model to use cd-{eject/insert}

2016-04-07 Thread Roger Pau Monne
Signed-off-by: Roger Pau Monné Cc: Ian Jackson Cc: Wei Liu --- tools/libxl/libxl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 9d785a4..232e2c1 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -2909,6 +2909,12 @@ int lib