Re: [Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

2015-01-06 Thread Chao Peng
On Tue, Jan 06, 2015 at 09:51:37AM +, Wei Liu wrote: > On Tue, Jan 06, 2015 at 05:46:12PM +0800, Chao Peng wrote: > [...] > > > Coding style, no space after "(" and before ")". > > > > > > I missed this issue when I reviewed your previous patches. You can fix > > > this style problem here whi

Re: [Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

2015-01-06 Thread Wei Liu
On Tue, Jan 06, 2015 at 05:46:12PM +0800, Chao Peng wrote: [...] > > Coding style, no space after "(" and before ")". > > > > I missed this issue when I reviewed your previous patches. You can fix > > this style problem here while you're at it. > Sure, I will fix them all. If you plan to fix the

Re: [Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

2015-01-06 Thread Chao Peng
On Mon, Jan 05, 2015 at 12:25:05PM +, Wei Liu wrote: > On Tue, Dec 23, 2014 at 04:54:38PM +0800, Chao Peng wrote: > [...] > > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > > index 3737c7e..f4534ec 100644 > > --- a/tools/libxl/xl_cmdimpl.c > > +++ b/tools/libxl/xl_cmdimpl.c

Re: [Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

2015-01-05 Thread Wei Liu
On Tue, Dec 23, 2014 at 04:54:38PM +0800, Chao Peng wrote: [...] > diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c > index 3737c7e..f4534ec 100644 > --- a/tools/libxl/xl_cmdimpl.c > +++ b/tools/libxl/xl_cmdimpl.c > @@ -7845,12 +7845,13 @@ out: > } > > #ifdef LIBXL_HAVE_PSR_CMT

[Xen-devel] [PATCH 3/4] tools: libxl: code preparation for MBM

2014-12-23 Thread Chao Peng
Make some internal routines common so that total/local memory bandwidth monitoring in the next patch can make use of them. Signed-off-by: Chao Peng --- tools/libxl/libxl_psr.c | 42 ++ tools/libxl/xl_cmdimpl.c | 51