Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-30 Thread Jonathan Davies
On Tue, Mar 29, 2016 at 08:41:54PM +0100, David Scott wrote: > > > On 29 Mar 2016, at 17:38, Wei Liu wrote: > > > > On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: > >> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: > >>> On 03/24/2016 06:49 PM, Andrew Cooper w

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-30 Thread Wei Liu
On Wed, Mar 30, 2016 at 04:46:58PM +0100, Jonathan Davies wrote: [...] > > >> Andrew's guess was close, but the wrong way around -- please could you > > >> try the > > >> following with the older compiler? > > >> > > >> let req = {Packet.tid=tid; Packet.rid=rid; Packet.ty=ty; > > >> Packet.data=

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-29 Thread David Scott
> On 29 Mar 2016, at 17:38, Wei Liu wrote: > > On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: >> On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: >>> On 03/24/2016 06:49 PM, Andrew Cooper wrote: On 24/03/2016 22:22, Boris Ostrovsky wrote: > On 03/17/201

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-29 Thread Wei Liu
On Tue, Mar 29, 2016 at 10:08:30AM +0100, Jonathan Davies wrote: > On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: > > On 03/24/2016 06:49 PM, Andrew Cooper wrote: > > >On 24/03/2016 22:22, Boris Ostrovsky wrote: > > >>On 03/17/2016 01:51 PM, Jonathan Davies wrote: > > >>>Encapsula

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-29 Thread Boris Ostrovsky
On 03/29/2016 05:08 AM, Jonathan Davies wrote: On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: On 03/24/2016 06:49 PM, Andrew Cooper wrote: On 24/03/2016 22:22, Boris Ostrovsky wrote: On 03/17/2016 01:51 PM, Jonathan Davies wrote: Encapsulate the request in a record that is p

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-29 Thread Jonathan Davies
On Thu, Mar 24, 2016 at 07:57:30PM -0400, Boris Ostrovsky wrote: > On 03/24/2016 06:49 PM, Andrew Cooper wrote: > >On 24/03/2016 22:22, Boris Ostrovsky wrote: > >>On 03/17/2016 01:51 PM, Jonathan Davies wrote: > >>>Encapsulate the request in a record that is passed from do_input to > >>>process_pac

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-24 Thread Boris Ostrovsky
On 03/24/2016 06:49 PM, Andrew Cooper wrote: On 24/03/2016 22:22, Boris Ostrovsky wrote: On 03/17/2016 01:51 PM, Jonathan Davies wrote: Encapsulate the request in a record that is passed from do_input to process_packet and input_handle_error. This will be helpful when keeping track of the requ

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-24 Thread Andrew Cooper
On 24/03/2016 22:22, Boris Ostrovsky wrote: > On 03/17/2016 01:51 PM, Jonathan Davies wrote: >> Encapsulate the request in a record that is passed from do_input to >> process_packet and input_handle_error. >> >> This will be helpful when keeping track of the requests made as part >> of a >> transac

Re: [Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-24 Thread Boris Ostrovsky
On 03/17/2016 01:51 PM, Jonathan Davies wrote: Encapsulate the request in a record that is passed from do_input to process_packet and input_handle_error. This will be helpful when keeping track of the requests made as part of a transaction. Signed-off-by: Jonathan Davies Reviewed-by: Andrew Co

[Xen-devel] [PATCH 3/7] oxenstored: refactor request processing

2016-03-18 Thread Jonathan Davies
Encapsulate the request in a record that is passed from do_input to process_packet and input_handle_error. This will be helpful when keeping track of the requests made as part of a transaction. Signed-off-by: Jonathan Davies Reviewed-by: Andrew Cooper Reviewed-by: Jon Ludlam Reviewed-by: Euan