[Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

1. Kconfig: * Added Kconfigs for common monitor vm-events: # see files: common/Kconfig, x86/Kconfig HAS_VM_EVENT_WRITE_CTRLREG HAS_VM_EVENT_SINGLESTEP HAS_VM_EVENT_SOFTWARE_BREAKPOINT HAS_VM_EVENT_GUEST_REQUEST 2. Moved monitor_domctl from arch-side to common-side 2.1. Moved

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

> > > So I don't particularly like this #if check here. IMHO this should be done > in arch-specific function that you call from here that is just empty for > ARM. It could be a static inline function as it's rather small. > > >> +#if CONFIG_X86 >> > +if ( VM_EVENT_X86_CR3 ==

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU wrote: > 1. Kconfig: > * Added Kconfigs for common monitor vm-events: > # see files: common/Kconfig, x86/Kconfig > HAS_VM_EVENT_WRITE_CTRLREG > HAS_VM_EVENT_SINGLESTEP > HAS_VM_EVENT_SOFTWARE_BREAKPOINT >

Re: [Xen-devel] [PATCH 3/7] xen/vm-events: Move monitor_domctl to common-side.

On 2/8/2016 8:15 PM, Tamas K Lengyel wrote: On Mon, Feb 8, 2016 at 9:57 AM, Corneliu ZUZU > wrote: +#if CONFIG_X86 Wouldn't it be safe to include these headers on ARM as well? +#include /* for VM_EVENT_X86_CR3 */