Re: [Xen-devel] [PATCH 4/4] xen: add a gcov Kconfig option

2016-08-30 Thread Doug Goldstein
> On Aug 30, 2016, at 8:06 AM, Wei Liu wrote: > > On Tue, Aug 30, 2016 at 06:56:36AM -0600, Jan Beulich wrote: > On 30.08.16 at 14:01, wrote: >>> Signed-off-by: Wei Liu >> >> Acked-by: Jan Beulich >> >> with one adjustment (see below). Thanks for doing this Wei. I agree with Jan's revi

Re: [Xen-devel] [PATCH 4/4] xen: add a gcov Kconfig option

2016-08-30 Thread Wei Liu
On Tue, Aug 30, 2016 at 06:56:36AM -0600, Jan Beulich wrote: > >>> On 30.08.16 at 14:01, wrote: > > Signed-off-by: Wei Liu > > Acked-by: Jan Beulich > > with one adjustment (see below). > > > Cc: Konrad Rzeszutek Wilk > > Cc: Stefano Stabellini > > Cc: Tim Deegan > > Cc: Doug Goldstein >

Re: [Xen-devel] [PATCH 4/4] xen: add a gcov Kconfig option

2016-08-30 Thread Jan Beulich
>>> On 30.08.16 at 14:01, wrote: > Signed-off-by: Wei Liu Acked-by: Jan Beulich with one adjustment (see below). > Cc: Konrad Rzeszutek Wilk > Cc: Stefano Stabellini > Cc: Tim Deegan > Cc: Doug Goldstein > > Would like to have it default to DEBUG, but we also need to check > compiler to

[Xen-devel] [PATCH 4/4] xen: add a gcov Kconfig option

2016-08-30 Thread Wei Liu
Signed-off-by: Wei Liu --- Cc: Andrew Cooper Cc: George Dunlap Cc: Ian Jackson Cc: Jan Beulich Cc: Konrad Rzeszutek Wilk Cc: Stefano Stabellini Cc: Tim Deegan Cc: Doug Goldstein Would like to have it default to DEBUG, but we also need to check compiler to be gcc. I couldn't figure out how