Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-26 Thread Julien Grall
Hi Chris, On 07/07/17 19:08, Chris Patterson wrote: On Fri, Jul 7, 2017 at 12:25 PM, Julien Grall wrote: Hi Chris, On 06/07/17 23:00, Chris Patterson wrote: The purpose of tegra_interrupt_compat is to maintain a tegra-specific whitelist of interrupt controllers we know how to route. Presu

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-26 Thread Julien Grall
Hi Chris, Sorry for the late reply. On 24/07/17 20:38, Chris Patterson wrote: On Fri, Jul 7, 2017 at 2:53 PM, Chris Patterson wrote: On Fri, Jul 7, 2017 at 12:30 PM, Julien Grall wrote: Hi Chris, On 07/07/17 00:12, Chris Patterson wrote: So why do you want the hardware domain to interac

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-24 Thread Chris Patterson
On Fri, Jul 7, 2017 at 2:53 PM, Chris Patterson wrote: > On Fri, Jul 7, 2017 at 12:30 PM, Julien Grall wrote: >> Hi Chris, >> >> On 07/07/17 00:12, Chris Patterson wrote: So why do you want the hardware domain to interact with the ictlr? Could not you hide it completely?

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Chris Patterson
On Fri, Jul 7, 2017 at 12:30 PM, Julien Grall wrote: > Hi Chris, > > On 07/07/17 00:12, Chris Patterson wrote: >>> >>> >>> So why do you want the hardware domain to interact with the ictlr? Could >>> not >>> you hide it completely? >>> >> >> snip >> >>> What would happen if you enable the interrup

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Chris Patterson
On Fri, Jul 7, 2017 at 12:25 PM, Julien Grall wrote: > Hi Chris, > > > On 06/07/17 23:00, Chris Patterson wrote: The purpose of tegra_interrupt_compat is to maintain a tegra-specific whitelist of interrupt controllers we know how to route. Presumably, there may be custom board

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Julien Grall
Hi Chris, On 07/07/17 00:12, Chris Patterson wrote: So why do you want the hardware domain to interact with the ictlr? Could not you hide it completely? snip What would happen if you enable the interrupt here for the guest? Should not you do it when the guest is requesting to enable (see v

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-07 Thread Julien Grall
Hi Chris, On 06/07/17 23:00, Chris Patterson wrote: The purpose of tegra_interrupt_compat is to maintain a tegra-specific whitelist of interrupt controllers we know how to route. Presumably, there may be custom boards out there that may have additional interrupt routing capabilities that this p

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-06 Thread Chris Patterson
> > So why do you want the hardware domain to interact with the ictlr? Could not > you hide it completely? > snip > What would happen if you enable the interrupt here for the guest? Should not > you do it when the guest is requesting to enable (see vgic_enable_irqs). > > > Also, how about EOI an

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-07-06 Thread Chris Patterson
>> The purpose of tegra_interrupt_compat is to maintain a tegra-specific >> whitelist of interrupt controllers we know how to route. Presumably, >> there may be custom boards out there that may have additional >> interrupt routing capabilities that this patch set would not support >> as-is. I'm n

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-18 Thread Julien Grall
Hello, On 06/04/2017 20:47, Chris Patterson wrote: From: "Chris Patterson" Tegra devices have a legacy interrupt controller (lic, or ictlr) that must be programmed in parallel with their primary GIC. For all intents and purposes, we treat these devices attached to this controller as connected

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-18 Thread Julien Grall
Hello Chris, On 17/04/2017 16:03, Chris Patterson wrote: +static const char * const tegra_dt_compat[] __initconst = +{ +"nvidia,tegra120", /* Tegra K1 */ This is still tegra120 (not tegra124), is that intended? If so, it is still missing from arch/arm*/boot/dts. Do you have a pointer? I

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-17 Thread Chris Patterson
>> +static const char * const tegra_dt_compat[] __initconst = >> +{ >> +"nvidia,tegra120", /* Tegra K1 */ > > This is still tegra120 (not tegra124), is that intended? If so, it is > still missing from arch/arm*/boot/dts. Do you have a pointer? It was not intended; thank you for catching it. I

Re: [Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-13 Thread Stefano Stabellini
On Thu, 6 Apr 2017, Chris Patterson wrote: > From: "Chris Patterson" > > Tegra devices have a legacy interrupt controller (lic, or ictlr) that > must be programmed in parallel with their primary GIC. For all intents > and purposes, we treat these devices attached to this controller as > connected

[Xen-devel] [PATCH 4/6] xen/arm: platforms: Add Tegra platform to support basic IRQ routing

2017-04-06 Thread Chris Patterson
From: "Chris Patterson" Tegra devices have a legacy interrupt controller (lic, or ictlr) that must be programmed in parallel with their primary GIC. For all intents and purposes, we treat these devices attached to this controller as connected to the primary GIC, as it will be handling their inter