Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-11 Thread Olaf Hering
On Thu, Sep 10, Ian Jackson wrote: > Wei Liu writes ("Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to > start xenstored"): > > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > > ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_A

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread Wei Liu
On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > On Wed, Jan 7, 2015 at 9:40 AM, Olaf Hering wrote: > > On Tue, Jan 06, Ian Campbell wrote: > > > >> On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: > >> > The shell wrapper in xenstored.service does not handle

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread Wei Liu
On Thu, Sep 10, 2015 at 04:01:06PM +0100, M A Young wrote: > On Thu, 10 Sep 2015, Wei Liu wrote: > > > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > > On Wed, Jan 7, 2015 at 9:40 AM, Olaf Hering wrote: > > > > On Tue, Jan 06, Ian Campbell wrote: > > > > > > >

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread George Dunlap
On Thu, Sep 10, 2015 at 4:01 PM, M A Young wrote: > On Thu, 10 Sep 2015, Wei Liu wrote: > >> On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: >> > On Wed, Jan 7, 2015 at 9:40 AM, Olaf Hering wrote: >> > > On Tue, Jan 06, Ian Campbell wrote:

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread George Dunlap
On Wed, Jan 7, 2015 at 9:40 AM, Olaf Hering wrote: > On Tue, Jan 06, Ian Campbell wrote: > >> On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: >> > The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. >> > >> > Create a separate wrapper script which is used

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread M A Young
On Thu, 10 Sep 2015, Wei Liu wrote: > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > On Wed, Jan 7, 2015 at 9:40 AM, Olaf Hering wrote: > > > On Tue, Jan 06, Ian Campbell wrote: > > > > > >> On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: > > >> > The

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-09-10 Thread Ian Jackson
Wei Liu writes ("Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored"): > On Thu, Sep 10, 2015 at 03:19:35PM +0100, George Dunlap wrote: > > ExecStart=/usr/bin/env $XENSTORED --no-fork $XENSTORED_ARGS > > And the difference between these two a

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Jackson wrote: Olaf Hering writes ([PATCH 7/7] tools/hotplug: add wrapper to start xenstored): The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. ... +XENSTORED_LIBEXEC = xenstored.sh Should be in /etc as previously discussed. Previously I

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Olaf Hering
On Tue, Jan 06, Ian Campbell wrote: On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. Create a separate wrapper script which is used in the sysv runlevel script and in systemd xenstored.service. It preserves

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Konrad Rzeszutek Wilk
On Wed, Jan 07, 2015 at 10:49:38AM +0100, Olaf Hering wrote: On Tue, Jan 06, Ian Jackson wrote: Olaf Hering writes ([PATCH 7/7] tools/hotplug: add wrapper to start xenstored): The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. ... +XENSTORED_LIBEXEC =

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Ian Jackson
Olaf Hering writes (Re: [PATCH 7/7] tools/hotplug: add wrapper to start xenstored): If I recall correctly the point of the current 'sh -c exec ...' stunt was to expand the XENSTORE variable from the sysconfig file. But this approach leads to failures with SELinux because the socket passing

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-07 Thread Konrad Rzeszutek Wilk
On Wed, Jan 07, 2015 at 03:27:15PM +, Ian Jackson wrote: Olaf Hering writes (Re: [PATCH 7/7] tools/hotplug: add wrapper to start xenstored): If I recall correctly the point of the current 'sh -c exec ...' stunt was to expand the XENSTORE variable from the sysconfig file. But this

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-06 Thread Ian Campbell
On Fri, 2014-12-19 at 12:25 +0100, Olaf Hering wrote: The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. Create a separate wrapper script which is used in the sysv runlevel script and in systemd xenstored.service. It preserves existing behaviour by handling the

Re: [Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2015-01-06 Thread Ian Jackson
Olaf Hering writes ([PATCH 7/7] tools/hotplug: add wrapper to start xenstored): The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. ... +XENSTORED_LIBEXEC = xenstored.sh Should be in /etc as previously discussed. Previously I wrote: Bottom line: as relevant maintainer,

[Xen-devel] [PATCH 7/7] tools/hotplug: add wrapper to start xenstored

2014-12-19 Thread Olaf Hering
The shell wrapper in xenstored.service does not handle XENSTORE_TRACE. Create a separate wrapper script which is used in the sysv runlevel script and in systemd xenstored.service. It preserves existing behaviour by handling the XENSTORE_TRACE boolean. It also implements the handling of