Re: [Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

2015-12-04 Thread Daniel P. Berrange
On Thu, Dec 03, 2015 at 11:13:06PM -0700, Jim Fehlig wrote: > On 11/26/2015 09:59 AM, Ian Campbell wrote: > > libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL > > with cfg->verInfo->xen_version_major, however AFAICT they both (either > > inherently, or through there use of

Re: [Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

2015-12-04 Thread Daniel P. Berrange
On Fri, Dec 04, 2015 at 02:19:33PM +, Ian Campbell wrote: > On Fri, 2015-12-04 at 10:01 +, Daniel P. Berrange wrote: > > On Thu, Dec 03, 2015 at 11:13:06PM -0700, Jim Fehlig wrote: > > > On 11/26/2015 09:59 AM, Ian Campbell wrote: > > > > libxlConnectDomainXMLFromNative calls both

Re: [Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

2015-12-04 Thread Ian Campbell
On Fri, 2015-12-04 at 10:01 +, Daniel P. Berrange wrote: > On Thu, Dec 03, 2015 at 11:13:06PM -0700, Jim Fehlig wrote: > > On 11/26/2015 09:59 AM, Ian Campbell wrote: > > > libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL > > > with cfg->verInfo->xen_version_major, however

Re: [Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

2015-12-03 Thread Jim Fehlig
On 11/26/2015 09:59 AM, Ian Campbell wrote: > libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL > with cfg->verInfo->xen_version_major, however AFAICT they both (either > inherently, or through there use of xenParseConfigCommon expect a > value from xenConfigVersionEnum (which

[Xen-devel] [PATCH LIBVIRT v1 1/2] libxl: Correct value for xendConfigVersion to xen{Parse, Format}ConfigCommon

2015-11-26 Thread Ian Campbell
libxlConnectDomainXMLFromNative calls both xenParseXM and xenParseXL with cfg->verInfo->xen_version_major, however AFAICT they both (either inherently, or through there use of xenParseConfigCommon expect a value from xenConfigVersionEnum (which does not correspond to xen_version_major). The