Re: [Xen-devel] [PATCH RESEND 2/4] qdisk, hw/block/xen_disk: Removal of grant mapping

2016-06-02 Thread David Vrabel
On 02/06/16 10:57, Paulina Szubarczyk wrote: > On Thu, 2016-06-02 at 11:41 +0200, Roger Pau Monné wrote: >> On Tue, May 31, 2016 at 06:44:56AM +0200, Paulina Szubarczyk wrote: >>> Grant mapping related functions and variables are removed >>> on behalf of grant copy operation introduced in following

Re: [Xen-devel] [PATCH RESEND 2/4] qdisk, hw/block/xen_disk: Removal of grant mapping

2016-06-02 Thread Paulina Szubarczyk
On Thu, 2016-06-02 at 11:41 +0200, Roger Pau Monné wrote: > On Tue, May 31, 2016 at 06:44:56AM +0200, Paulina Szubarczyk wrote: > > Grant mapping related functions and variables are removed > > on behalf of grant copy operation introduced in following commits. > > As David says, you should not rem

Re: [Xen-devel] [PATCH RESEND 2/4] qdisk, hw/block/xen_disk: Removal of grant mapping

2016-06-02 Thread Roger Pau Monné
On Tue, May 31, 2016 at 06:44:56AM +0200, Paulina Szubarczyk wrote: > Grant mapping related functions and variables are removed > on behalf of grant copy operation introduced in following commits. As David says, you should not remove this before adding a suitable replacement, or else you are brea

Re: [Xen-devel] [PATCH RESEND 2/4] qdisk, hw/block/xen_disk: Removal of grant mapping

2016-05-31 Thread David Vrabel
On 31/05/2016 05:44, Paulina Szubarczyk wrote: > Grant mapping related functions and variables are removed > on behalf of grant copy operation introduced in following commits. You should remove this after adding the replacement or you break bisection. David __

[Xen-devel] [PATCH RESEND 2/4] qdisk, hw/block/xen_disk: Removal of grant mapping

2016-05-30 Thread Paulina Szubarczyk
Grant mapping related functions and variables are removed on behalf of grant copy operation introduced in following commits. --- hw/block/xen_disk.c | 284 ++-- 1 file changed, 10 insertions(+), 274 deletions(-) diff --git a/hw/block/xen_disk.c b/hw