[Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-13 Thread Andrew Cooper
The event channel ABI passes a pointer to a subop-specific structure. Some of these structures however are smaller than the pointers passed in the ABI; EVTCHNOP_send specifically passes a 4 byte evtchn port, using a 4 or 8 byte pointer. For translated guests (x86 HVM and all ARM), passing the por

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-13 Thread Paul Durrant
Pau Monne > Subject: [Xen-devel] [PATCH RFC] xen/evtchn: Implement > EVTCHNOP_send_imm as a companian to EVTCHNOP_send > > The event channel ABI passes a pointer to a subop-specific structure. Some > of > these structures however are smaller than the pointers passed in the ABI;

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-13 Thread Juergen Groß
On 07/13/2017 09:50 AM, Andrew Cooper wrote: The event channel ABI passes a pointer to a subop-specific structure. Some of these structures however are smaller than the pointers passed in the ABI; EVTCHNOP_send specifically passes a 4 byte evtchn port, using a 4 or 8 byte pointer. For translate

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-13 Thread Wei Liu
On Thu, Jul 13, 2017 at 12:14:35PM +0200, Juergen Groß wrote: > On 07/13/2017 09:50 AM, Andrew Cooper wrote: > > The event channel ABI passes a pointer to a subop-specific structure. Some > > of > > these structures however are smaller than the pointers passed in the ABI; > > EVTCHNOP_send specif

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-13 Thread Jan Beulich
>>> Andrew Cooper 07/13/17 9:50 AM >>> >RFC: is it worth converting the close, unmask, reset (and possibly >expand_array) as well? I can't see close and even more so reset to be performance critical. Unmask otoh may be (depending on use); no sure about expand_array. Jan ___

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-14 Thread Paul Durrant
ger Pau Monne > Subject: Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement > EVTCHNOP_send_imm as a companian to EVTCHNOP_send > > >>> Andrew Cooper 07/13/17 9:50 AM >>> > >RFC: is it worth converting the close, unmask, reset (and possibly > >expand_a

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-14 Thread Jan Beulich
>>> On 13.07.17 at 09:50, wrote: > --- a/xen/common/event_channel.c > +++ b/xen/common/event_channel.c > @@ -1098,6 +1098,10 @@ long do_event_channel_op(int cmd, > XEN_GUEST_HANDLE_PARAM(void) arg) > break; > } > > +case EVTCHNOP_send_imm: > +rc = evtchn_send(current->

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-17 Thread Stefano Stabellini
On Fri, 14 Jul 2017, Jan Beulich wrote: > >>> On 13.07.17 at 09:50, wrote: > > --- a/xen/common/event_channel.c > > +++ b/xen/common/event_channel.c > > @@ -1098,6 +1098,10 @@ long do_event_channel_op(int cmd, > > XEN_GUEST_HANDLE_PARAM(void) arg) > > break; > > } > > > > +cas

Re: [Xen-devel] [PATCH RFC] xen/evtchn: Implement EVTCHNOP_send_imm as a companian to EVTCHNOP_send

2017-07-17 Thread Andrew Cooper
On 17/07/2017 19:30, Stefano Stabellini wrote: > On Fri, 14 Jul 2017, Jan Beulich wrote: > On 13.07.17 at 09:50, wrote: >>> --- a/xen/common/event_channel.c >>> +++ b/xen/common/event_channel.c >>> @@ -1098,6 +1098,10 @@ long do_event_channel_op(int cmd, >>> XEN_GUEST_HANDLE_PARAM(void) arg)