Re: [Xen-devel] [PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert

2015-06-26 Thread Rob Hoes
On 24 Jun 2015, at 16:26, Ian Jackson ian.jack...@eu.citrix.com wrote: Rob Hoes writes ([PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert): Signed-off-by: Rob Hoes rob.h...@citrix.com if (libxl_get_stubdom_id(ctx, domid) != 0) { LOG(ERROR,

[Xen-devel] [PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert

2015-06-24 Thread Rob Hoes
Signed-off-by: Rob Hoes rob.h...@citrix.com --- tools/libxl/libxl.c | 12 ++-- tools/libxl/libxl_device.c | 6 +++--- tools/libxl/libxl_qmp.c | 4 +++- tools/libxl/libxl_types.idl | 22 +- 4 files changed, 33 insertions(+), 11 deletions(-) diff --git

Re: [Xen-devel] [PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert

2015-06-24 Thread Ian Jackson
Rob Hoes writes ([PATCH RFC 8/9] libxl: introduce specific error codes in libxl_device_cdrom_insert): Signed-off-by: Rob Hoes rob.h...@citrix.com if (libxl_get_stubdom_id(ctx, domid) != 0) { LOG(ERROR, cdrom-insert doesn't work for stub domains); -rc = ERROR_INVAL; +