Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-09-22 Thread Ian Campbell
On Mon, 2015-09-21 at 18:30 +0100, Andrew Cooper wrote: > On 21/09/15 18:13, Ian Jackson wrote: > > Andrew Cooper writes ("Re: [Xen-devel] [PATCH RFC tools 1/6] tools: > > Refactor "xentoollog" into its own library"): > > > On 21/09/15 17:17, Ian Jacks

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-09-21 Thread Andrew Cooper
On 21/09/15 18:13, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor > "xentoollog" into its own library"): >> On 21/09/15 17:17, Ian Jackson wrote: >>> Do you mean that statement expressions (originally

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-09-21 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library"): > On 21/09/15 17:17, Ian Jackson wrote: > > Do you mean that statement expressions (originally a GNU extension) > > should be avoided in tools code

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-09-21 Thread Andrew Cooper
On 21/09/15 17:17, Ian Jackson wrote: > Andrew Cooper writes ("Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor > "xentoollog" into its own library"): >> On 10/06/15 12:36, Ian Campbell wrote: >>> +

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-09-21 Thread Ian Jackson
Andrew Cooper writes ("Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library"): > On 10/06/15 12:36, Ian Campbell wrote: > > + > > +#define XTL_NEW_LOGGER(LOGGER,buffer) ({\ > > +

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-06-11 Thread Ian Campbell
On Thu, 2015-06-11 at 13:06 +0100, Jan Beulich wrote: > >>> On 11.06.15 at 13:35, wrote: > > On Thu, 2015-06-11 at 12:20 +0100, Andrew Cooper wrote: > >> As part of the tidyup, we should choose a particular C standard (89, > >> probably) and ensure that the API/ABI complies with `gcc -std=c$VER >

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-06-11 Thread Jan Beulich
>>> On 11.06.15 at 13:35, wrote: > On Thu, 2015-06-11 at 12:20 +0100, Andrew Cooper wrote: >> As part of the tidyup, we should choose a particular C standard (89, >> probably) and ensure that the API/ABI complies with `gcc -std=c$VER >> -pedantic`. This will help to provide a consistent API on ot

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-06-11 Thread Ian Campbell
On Thu, 2015-06-11 at 12:20 +0100, Andrew Cooper wrote: > On 10/06/15 12:36, Ian Campbell wrote: > > + > > +#define XTL_NEW_LOGGER(LOGGER,buffer) ({\ > > +xentoollog_logger_##LOGGER *new_consumer; \ > > +

Re: [Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-06-11 Thread Andrew Cooper
On 10/06/15 12:36, Ian Campbell wrote: > + > +#define XTL_NEW_LOGGER(LOGGER,buffer) ({\ > +xentoollog_logger_##LOGGER *new_consumer; \ > +\ > +(buffer).vtable.vm

[Xen-devel] [PATCH RFC tools 1/6] tools: Refactor "xentoollog" into its own library

2015-06-10 Thread Ian Campbell
In attempting to disaggregate libxenctrl I found that many of the pieces were going to want access to this library, so split it out (as it probably should always have been). Various build adjustments are needed. In particular things which use xtl_* themselves now need to explicity link against the