Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Tamas K Lengyel
On Thu, Mar 12, 2015 at 1:57 PM, Julien Grall julien.gr...@linaro.org wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: @@ -1090,6 +1098,8 @@ void p2m_teardown(struct domain *d) p2m_free_vmid(d); +radix_tree_destroy(p2m-mem_access_settings, NULL); +

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Julien Grall
On 12/03/15 13:18, Tamas K Lengyel wrote: +struct radix_tree_root mem_access_settings; }; /* List of possible type for each page in the p2m entry. @@ -217,6 +230,26 @@ static inline int get_page_and_type(struct page_info *page, /* get host p2m table */

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 13:22 +0100, Tamas K Lengyel wrote: I guess naming this patch something like groundwork for mem_access support would be more descriptive. Adding everything when they are actually getting used would have resulted in a massive patch that I think would have been harder to

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 13:25 +, Julien Grall wrote: On 12/03/15 13:18, Tamas K Lengyel wrote: +struct radix_tree_root mem_access_settings; }; /* List of possible type for each page in the p2m entry. @@ -217,6 +230,26 @@ static inline int

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 12:57 +, Julien Grall wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: @@ -1090,6 +1098,8 @@ void p2m_teardown(struct domain *d) p2m_free_vmid(d); +radix_tree_destroy(p2m-mem_access_settings, NULL); + spin_unlock(p2m-lock);

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Andrew Cooper
On 12/03/15 13:56, Ian Campbell wrote: On Thu, 2015-03-12 at 12:57 +, Julien Grall wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: @@ -1090,6 +1098,8 @@ void p2m_teardown(struct domain *d) p2m_free_vmid(d); +radix_tree_destroy(p2m-mem_access_settings, NULL); +

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Ian Campbell
On Thu, 2015-03-12 at 16:56 +, Julien Grall wrote: On 12/03/15 14:10, Andrew Cooper wrote: On 12/03/15 13:56, Ian Campbell wrote: On Thu, 2015-03-12 at 12:57 +, Julien Grall wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: @@ -1090,6 +1098,8 @@ void

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Julien Grall
On 12/03/15 14:10, Andrew Cooper wrote: On 12/03/15 13:56, Ian Campbell wrote: On Thu, 2015-03-12 at 12:57 +, Julien Grall wrote: Hi Tamas, On 06/03/15 21:24, Tamas K Lengyel wrote: @@ -1090,6 +1098,8 @@ void p2m_teardown(struct domain *d) p2m_free_vmid(d); +

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Tamas K Lengyel
On Thu, Mar 12, 2015 at 12:27 PM, Ian Campbell ian.campb...@citrix.com wrote: On Fri, 2015-03-06 at 22:24 +0100, Tamas K Lengyel wrote: Add necessary changes for page table construction routines to pass the default access information. You do more than just plumb through the access

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-12 Thread Ian Campbell
On Fri, 2015-03-06 at 22:24 +0100, Tamas K Lengyel wrote: Add necessary changes for page table construction routines to pass the default access information. You do more than just plumb through the access information variable thoguh. You seem to setup preemption support, add some tother

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-11 Thread Stefano Stabellini
On Fri, 6 Mar 2015, Tamas K Lengyel wrote: Add necessary changes for page table construction routines to pass the default access information. We store the p2m_access_t info in a Radix tree as the PTE lacks enough software programmable bits. Signed-off-by: Tamas K Lengyel

Re: [Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-11 Thread Tamas K Lengyel
On Wed, Mar 11, 2015 at 5:07 PM, Stefano Stabellini stefano.stabell...@eu.citrix.com wrote: On Fri, 6 Mar 2015, Tamas K Lengyel wrote: Add necessary changes for page table construction routines to pass the default access information. We store the p2m_access_t info in a Radix tree as the PTE

[Xen-devel] [PATCH V13 1/7] xen/arm: p2m changes for mem_access support

2015-03-06 Thread Tamas K Lengyel
Add necessary changes for page table construction routines to pass the default access information. We store the p2m_access_t info in a Radix tree as the PTE lacks enough software programmable bits. Signed-off-by: Tamas K Lengyel tkleng...@sec.in.tum.de --- v13: - Rename access_in_use to