[Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
Currently it is only possible to set mem_access restrictions only for a contiguous range of GFNs (or, as a particular case, for a single GFN). This patch introduces a new libxc function taking an array of GFNs. The alternative would be to set each page in turn, using a userspace-HV roundtrip for ea

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Wei Liu
On Fri, Sep 02, 2016 at 11:51:06AM +0300, Razvan Cojocaru wrote: > Currently it is only possible to set mem_access restrictions only for > a contiguous range of GFNs (or, as a particular case, for a single GFN). > This patch introduces a new libxc function taking an array of GFNs. > The alternative

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 10:51, wrote: > Changes since V1 / RFC: > - Renamed xc_set_mem_access_sparse() to xc_set_mem_access_multi(), >and XENMEM_access_op_set_access_sparse to >XENMEM_access_op_set_access_multi. > - Renamed the 'nr' parameter to 'size'. Why? > - Wrapped long line in the im

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 12:02, wrote: On 02.09.16 at 10:51, wrote: >> @@ -320,6 +321,23 @@ int compat_memory_op(unsigned int cmd, >> XEN_GUEST_HANDLE_PARAM(void) compat) >> break; >> } >> >> +case XENMEM_access_op: >> +{ >> +#define XLAT_mem_access_op_HNDL

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 01:02 PM, Jan Beulich wrote: On 02.09.16 at 10:51, wrote: >> Changes since V1 / RFC: >> - Renamed xc_set_mem_access_sparse() to xc_set_mem_access_multi(), >>and XENMEM_access_op_set_access_sparse to >>XENMEM_access_op_set_access_multi. >> - Renamed the 'nr' parameter t

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 13:18, wrote: > On 09/02/2016 01:02 PM, Jan Beulich wrote: > On 02.09.16 at 10:51, wrote: >>> Changes since V1 / RFC: >>> - Renamed xc_set_mem_access_sparse() to xc_set_mem_access_multi(), >>>and XENMEM_access_op_set_access_sparse to >>>XENMEM_access_op_set_access_

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 01:02 PM, Jan Beulich wrote: >> +/* >> > + * Corresponding list of access settings for pfn_list >> > + * Used only with XENMEM_access_op_set_access_multi >> > + */ >> > +XEN_GUEST_HANDLE(uint8) access_list; > And for both of them - I don't think the arrays are mean

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 14:21, wrote: > On 09/02/2016 01:02 PM, Jan Beulich wrote: >>> +/* >>> > + * Corresponding list of access settings for pfn_list >>> > + * Used only with XENMEM_access_op_set_access_multi >>> > + */ >>> > +XEN_GUEST_HANDLE(uint8) access_list; >> And for both o

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 03:33 PM, Jan Beulich wrote: On 02.09.16 at 14:21, wrote: >> On 09/02/2016 01:02 PM, Jan Beulich wrote: +/* > + * Corresponding list of access settings for pfn_list > + * Used only with XENMEM_access_op_set_access_multi > + */ > +XEN_GUES

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 14:41, wrote: > On 09/02/2016 03:33 PM, Jan Beulich wrote: > On 02.09.16 at 14:21, wrote: >>> On 09/02/2016 01:02 PM, Jan Beulich wrote: > +/* >> + * Corresponding list of access settings for pfn_list >> + * Used only with XENMEM_access_op_set_access

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 03:56 PM, Jan Beulich wrote: On 02.09.16 at 14:41, wrote: >> On 09/02/2016 03:33 PM, Jan Beulich wrote: >> On 02.09.16 at 14:21, wrote: On 09/02/2016 01:02 PM, Jan Beulich wrote: >> +/* >>> + * Corresponding list of access settings for pfn_list >>>

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 15:03, wrote: > On 09/02/2016 03:56 PM, Jan Beulich wrote: > On 02.09.16 at 14:41, wrote: >>> On 09/02/2016 03:33 PM, Jan Beulich wrote: >>> On 02.09.16 at 14:21, wrote: > On 09/02/2016 01:02 PM, Jan Beulich wrote: >>> +/* + * Corresponding lis

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Julien Grall
Hello Razvan, On 02/09/16 09:51, Razvan Cojocaru wrote: Currently it is only possible to set mem_access restrictions only for a contiguous range of GFNs (or, as a particular case, for a single GFN). This patch introduces a new libxc function taking an array of GFNs. The alternative would be to s

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 04:17 PM, Julien Grall wrote: > Hello Razvan, Hello Julien, thanks for the email! > On 02/09/16 09:51, Razvan Cojocaru wrote: >> Currently it is only possible to set mem_access restrictions only for >> a contiguous range of GFNs (or, as a particular case, for a single GFN). >> This

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 04:10 PM, Jan Beulich wrote: On 02.09.16 at 15:03, wrote: >> On 09/02/2016 03:56 PM, Jan Beulich wrote: >> On 02.09.16 at 14:41, wrote: On 09/02/2016 03:33 PM, Jan Beulich wrote: On 02.09.16 at 14:21, wrote: >> On 09/02/2016 01:02 PM, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Julien Grall
On 02/09/16 14:22, Razvan Cojocaru wrote: > On 09/02/2016 04:17 PM, Julien Grall wrote: >> Hello Razvan, > > Hello Julien, thanks for the email! > >> On 02/09/16 09:51, Razvan Cojocaru wrote: >>> Currently it is only possible to set mem_access restrictions only for >>> a contiguous range of GFN

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 04:26 PM, Julien Grall wrote: > > > On 02/09/16 14:22, Razvan Cojocaru wrote: >> On 09/02/2016 04:17 PM, Julien Grall wrote: >>> Hello Razvan, >> >> Hello Julien, thanks for the email! >> >>> On 02/09/16 09:51, Razvan Cojocaru wrote: Currently it is only possible to set mem_acc

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Tamas K Lengyel
On Sep 2, 2016 05:45, "Jan Beulich" wrote: > > >>> On 02.09.16 at 13:18, wrote: > > On 09/02/2016 01:02 PM, Jan Beulich wrote: > > On 02.09.16 at 10:51, wrote: > >>> Changes since V1 / RFC: > >>> - Renamed xc_set_mem_access_sparse() to xc_set_mem_access_multi(), > >>>and XENMEM_access_o

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Jan Beulich
>>> On 02.09.16 at 16:50, wrote: > On Sep 2, 2016 05:45, "Jan Beulich" wrote: >> >> >>> On 02.09.16 at 13:18, wrote: >> > On 09/02/2016 01:02 PM, Jan Beulich wrote: >> > On 02.09.16 at 10:51, wrote: >> >>> Changes since V1 / RFC: >> >>> - Renamed xc_set_mem_access_sparse() to xc_set_mem_ac

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Tamas K Lengyel
On Sep 2, 2016 09:03, "Jan Beulich" wrote: > > >>> On 02.09.16 at 16:50, wrote: > > On Sep 2, 2016 05:45, "Jan Beulich" wrote: > >> > >> >>> On 02.09.16 at 13:18, wrote: > >> > On 09/02/2016 01:02 PM, Jan Beulich wrote: > >> > On 02.09.16 at 10:51, wrote: > >> >>> Changes since V1 / RFC: >

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Razvan Cojocaru
On 09/02/2016 06:13 PM, Tamas K Lengyel wrote: > On Sep 2, 2016 09:03, "Jan Beulich" > wrote: >> >> >>> On 02.09.16 at 16:50, > wrote: >> > On Sep 2, 2016 05:45, "Jan Beulich" > wrote: >> >> >> >> >>> On 02.09.16 at

Re: [Xen-devel] [PATCH V2] tools/libxc, xen/x86: Added xc_set_mem_access_multi()

2016-09-02 Thread Tamas K Lengyel
On Sep 2, 2016 09:17, "Razvan Cojocaru" wrote: > > On 09/02/2016 06:13 PM, Tamas K Lengyel wrote: > > On Sep 2, 2016 09:03, "Jan Beulich" > > wrote: > >> > >> >>> On 02.09.16 at 16:50, > > wrote: > >> > On Sep 2, 2016 05:45, "Jan Beulich" >