Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-28 Thread Jan Beulich
>>> On 28.08.15 at 12:54, wrote: > On Wed, Aug 26, 2015 at 07:06:00AM -0600, Jan Beulich wrote: >> >>> On 25.08.15 at 12:54, wrote: >> >> > +++ b/xen/arch/x86/xstate.c >> > @@ -214,6 +214,11 @@ void xsave(struct vcpu *v, uint64_t mask) >> > typeof(ptr->fpu_sse.fip.sel) fcs = ptr->fpu_ss

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-28 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 07:06:00AM -0600, Jan Beulich wrote: > >>> On 25.08.15 at 12:54, wrote: > > > +++ b/xen/arch/x86/xstate.c > > @@ -214,6 +214,11 @@ void xsave(struct vcpu *v, uint64_t mask) > > typeof(ptr->fpu_sse.fip.sel) fcs = ptr->fpu_sse.fip.sel; > > typeof(ptr->fpu_s

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 06:35:51AM -0600, Jan Beulich wrote: > >>> On 26.08.15 at 14:05, wrote: > > On 26/08/15 12:50, Jan Beulich wrote: > > On 26.08.15 at 12:12, wrote: > >>> On 25/08/15 11:54, Shuai Ruan wrote: > --- a/xen/arch/x86/traps.c > +++ b/xen/arch/x86/traps.c > @@ -

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-27 Thread Shuai Ruan
On Wed, Aug 26, 2015 at 11:12:02AM +0100, Andrew Cooper wrote: > On 25/08/15 11:54, Shuai Ruan wrote: > > This patch uses xsaves/xrstors instead of xsaveopt/xrstor > > to perform the xsave_area switching so that xen itself > > can benefit from them when available. > > > > For xsaves/xrstors only us

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-26 Thread Jan Beulich
>>> On 25.08.15 at 12:54, wrote: > @@ -896,9 +897,28 @@ long arch_do_domctl( > ret = -EFAULT; > > offset += sizeof(v->arch.xcr0_accum); > -if ( !ret && copy_to_guest_offset(evc->buffer, offset, > - (void *)v->

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-26 Thread Jan Beulich
>>> On 26.08.15 at 14:05, wrote: > On 26/08/15 12:50, Jan Beulich wrote: > On 26.08.15 at 12:12, wrote: >>> On 25/08/15 11:54, Shuai Ruan wrote: --- a/xen/arch/x86/traps.c +++ b/xen/arch/x86/traps.c @@ -936,9 +936,10 @@ void pv_cpuid(struct cpu_user_regs *regs) if

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-26 Thread Andrew Cooper
On 26/08/15 12:50, Jan Beulich wrote: On 26.08.15 at 12:12, wrote: >> On 25/08/15 11:54, Shuai Ruan wrote: >>> --- a/xen/arch/x86/hvm/hvm.c >>> +++ b/xen/arch/x86/hvm/hvm.c >>> @@ -2148,8 +2148,12 @@ static int hvm_save_cpu_xsave_states(struct domain >>> *d, hvm_domain_context_t *h) >>>

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-26 Thread Jan Beulich
>>> On 26.08.15 at 12:12, wrote: > On 25/08/15 11:54, Shuai Ruan wrote: >> --- a/xen/arch/x86/hvm/hvm.c >> +++ b/xen/arch/x86/hvm/hvm.c >> @@ -2148,8 +2148,12 @@ static int hvm_save_cpu_xsave_states(struct domain >> *d, hvm_domain_context_t *h) >> ctxt->xfeature_mask = xfeature_mask; >>

Re: [Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-26 Thread Andrew Cooper
On 25/08/15 11:54, Shuai Ruan wrote: > This patch uses xsaves/xrstors instead of xsaveopt/xrstor > to perform the xsave_area switching so that xen itself > can benefit from them when available. > > For xsaves/xrstors only use compact format. Add format conversion > support when perform guest os mig

[Xen-devel] [PATCH V4 2/4] x86/xsaves: enable xsaves/xrstors in xen

2015-08-25 Thread Shuai Ruan
This patch uses xsaves/xrstors instead of xsaveopt/xrstor to perform the xsave_area switching so that xen itself can benefit from them when available. For xsaves/xrstors only use compact format. Add format conversion support when perform guest os migration. Signed-off-by: Shuai Ruan --- xen/arc