Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 7:34 PM, Andrew Cooper wrote: > On 17/02/15 18:30, Tamas K Lengyel wrote: >>> All these whitespace changes here and further down don't really >>> belong in this patch - please again get this right when adding the >>> code. >> Same issue I mentioned in the other patch: git -

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Tamas K Lengyel
On Tue, Feb 17, 2015 at 3:17 PM, Jan Beulich wrote: On 13.02.15 at 17:33, wrote: >> @@ -1293,56 +1293,30 @@ int p2m_mem_paging_prep(struct domain *d, unsigned >> long gfn, uint64_t buffer) >> * >> * If the gfn was dropped the vcpu needs to be unpaused. >> */ >> -void p2m_mem_paging_re

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Andrew Cooper
On 17/02/15 18:30, Tamas K Lengyel wrote: >> All these whitespace changes here and further down don't really >> belong in this patch - please again get this right when adding the >> code. > Same issue I mentioned in the other patch: git -M can't track the > files if indentation is fixed as part of

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-17 Thread Jan Beulich
>>> On 13.02.15 at 17:33, wrote: > @@ -1293,56 +1293,30 @@ int p2m_mem_paging_prep(struct domain *d, unsigned > long gfn, uint64_t buffer) > * > * If the gfn was dropped the vcpu needs to be unpaused. > */ > -void p2m_mem_paging_resume(struct domain *d) > + > +void p2m_mem_paging_resume(str

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-13 Thread Tamas K Lengyel
On Fri, Feb 13, 2015 at 10:05 PM, Andrew Cooper wrote: > On 13/02/15 16:33, Tamas K Lengyel wrote: >> diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c >> index f988291..f89361e 100644 >> --- a/xen/common/vm_event.c >> +++ b/xen/common/vm_event.c >> @@ -357,6 +357,67 @@ int vm_event_get_r

Re: [Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-13 Thread Andrew Cooper
On 13/02/15 16:33, Tamas K Lengyel wrote: > diff --git a/xen/common/vm_event.c b/xen/common/vm_event.c > index f988291..f89361e 100644 > --- a/xen/common/vm_event.c > +++ b/xen/common/vm_event.c > @@ -357,6 +357,67 @@ int vm_event_get_response(struct domain *d, struct > vm_event_domain *ved, vm_ev

[Xen-devel] [PATCH V5 09/12] xen/vm_event: Decouple vm_event and mem_access.

2015-02-13 Thread Tamas K Lengyel
The vm_event subsystem has been artifically tied to the presence of mem_access. While mem_access does depend on vm_event, vm_event is an entirely independent subsystem that can be used for arbitrary function-offloading to helper apps in domains. This patch removes the dependency that mem_access nee