Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-17 Thread Julien Grall
Hi George, On 13/10/17 10:00, George Dunlap wrote: Changeset introduced "batch mode" to afl-harness, which allowed the handling of several inputs in sequence. Unfortunately, it introduced a file pointer leak when the file was larger than the maximum size. Restructure the code to always

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread George Dunlap
On 10/13/2017 11:31 AM, Jan Beulich wrote: On 13.10.17 at 12:23, wrote: >> On 10/13/2017 10:20 AM, Jan Beulich wrote: >> On 13.10.17 at 11:10, wrote: On 10/13/2017 10:06 AM, Jan Beulich wrote: On 13.10.17 at 11:00,

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread Jan Beulich
>>> On 13.10.17 at 12:23, wrote: > On 10/13/2017 10:20 AM, Jan Beulich wrote: > On 13.10.17 at 11:10, wrote: >>> On 10/13/2017 10:06 AM, Jan Beulich wrote: >>> On 13.10.17 at 11:00, wrote: > ---

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread George Dunlap
On 10/13/2017 10:20 AM, Jan Beulich wrote: On 13.10.17 at 11:10, wrote: >> On 10/13/2017 10:06 AM, Jan Beulich wrote: >> On 13.10.17 at 11:00, wrote: --- a/tools/fuzz/x86_instruction_emulator/afl-harness.c +++

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread Jan Beulich
>>> On 13.10.17 at 11:10, wrote: > On 10/13/2017 10:06 AM, Jan Beulich wrote: > On 13.10.17 at 11:00, wrote: >>> --- a/tools/fuzz/x86_instruction_emulator/afl-harness.c >>> +++ b/tools/fuzz/x86_instruction_emulator/afl-harness.c >>> @@

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread George Dunlap
On 10/13/2017 10:06 AM, Jan Beulich wrote: On 13.10.17 at 11:00, wrote: >> Changeset introduced "batch mode" to afl-harness, which allowed > > With (part of) the commit hash and the title inserted here and ... This should be `2b1cde7783` BTW. -George

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread George Dunlap
On 10/13/2017 10:06 AM, Jan Beulich wrote: On 13.10.17 at 11:00, wrote: >> Changeset introduced "batch mode" to afl-harness, which allowed > > With (part of) the commit hash and the title inserted here and ... Gah. :-) > >> ---

Re: [Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread Jan Beulich
>>> On 13.10.17 at 11:00, wrote: > Changeset introduced "batch mode" to afl-harness, which allowed With (part of) the commit hash and the title inserted here and ... > --- a/tools/fuzz/x86_instruction_emulator/afl-harness.c > +++

[Xen-devel] [PATCH for-4.10] fuzz/x86_emulate: Fix afl-harness batch mode file pointer leak

2017-10-13 Thread George Dunlap
Changeset introduced "batch mode" to afl-harness, which allowed the handling of several inputs in sequence. Unfortunately, it introduced a file pointer leak when the file was larger than the maximum size. Restructure the code to always close fp if we opened it. Signed-off-by: George Dunlap