Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-21 Thread Julien Grall
Hi, On 11/16/2017 10:45 PM, Andrew Cooper wrote: Ever since it was introduced in c/s bd1f0b45ff, hvm_save_cpu_msrs() has had a bug whereby it corrupts the HVM context stream if some, but fewer than the maximum number of MSRs are written. _hvm_init_entry() creates an hvm_save_descriptor with len

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-20 Thread Andrew Cooper
On 17/11/17 12:15, Jan Beulich wrote: On 16.11.17 at 23:45, wrote: >> Ever since it was introduced in c/s bd1f0b45ff, hvm_save_cpu_msrs() has had a >> bug whereby it corrupts the HVM context stream if some, but fewer than the >> maximum number of MSRs are written. >> >> _hvm_init_entry() crea

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-17 Thread Jan Beulich
>>> On 16.11.17 at 23:45, wrote: > Ever since it was introduced in c/s bd1f0b45ff, hvm_save_cpu_msrs() has had a > bug whereby it corrupts the HVM context stream if some, but fewer than the > maximum number of MSRs are written. > > _hvm_init_entry() creates an hvm_save_descriptor with length for

Re: [Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-17 Thread Wei Liu
On Thu, Nov 16, 2017 at 10:45:16PM +, Andrew Cooper wrote: > Ever since it was introduced in c/s bd1f0b45ff, hvm_save_cpu_msrs() has had a > bug whereby it corrupts the HVM context stream if some, but fewer than the > maximum number of MSRs are written. > > _hvm_init_entry() creates an hvm_sav

[Xen-devel] [PATCH for-4.10] x86/hvm: Don't corrupt the HVM context stream when writing the MSR record

2017-11-16 Thread Andrew Cooper
Ever since it was introduced in c/s bd1f0b45ff, hvm_save_cpu_msrs() has had a bug whereby it corrupts the HVM context stream if some, but fewer than the maximum number of MSRs are written. _hvm_init_entry() creates an hvm_save_descriptor with length for msr_count_max, but in the case that we write