[Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Andrew Cooper
This makes fields 0 and 1 true more often than they should be, resulting problems when handling events. Signed-off-by: Andrew Cooper CC: Ian Campbell CC: Ian Jackson CC: Wei Liu CC: Dave Scott CC: Zheng Li CC: Konrad Rzeszutek Wilk --- This was discovered with XenServers internal Coverity

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Zheng Li
On 26/11/2014 15:09, Andrew Cooper wrote: This makes fields 0 and 1 true more often than they should be, resulting problems when handling events. Indeed, looks like a mistake I made when rewriting the logic terms lately. The result is POLLUP or POLLERR events being returned in more categories

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Dave Scott
> On 26 Nov 2014, at 15:38, Zheng Li wrote: > > On 26/11/2014 15:09, Andrew Cooper wrote: >> This makes fields 0 and 1 true more often than they should be, resulting >> problems when handling events. > > Indeed, looks like a mistake I made when rewriting the logic terms lately. > The result is

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Konrad Rzeszutek Wilk
On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: > > > On 26 Nov 2014, at 15:38, Zheng Li wrote: > > > > On 26/11/2014 15:09, Andrew Cooper wrote: > >> This makes fields 0 and 1 true more often than they should be, resulting > >> problems when handling events. > > > > Indeed, looks l

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Andrew Cooper
On 26/11/14 18:41, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: >>> On 26 Nov 2014, at 15:38, Zheng Li wrote: >>> >>> On 26/11/2014 15:09, Andrew Cooper wrote: This makes fields 0 and 1 true more often than they should be, resulting problems

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Zheng Li
On 26/11/2014 19:03, Andrew Cooper wrote: Strictly speaking Zheng, not being a maintainer, can't ack the patch, given what I believe to be Xens current rules for these things. However, as the author of the code and comment in this thread, his ack can reasonably be considered equivalent to a Revi

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Dave Scott
> On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk > wrote: > > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: >> >>> On 26 Nov 2014, at 15:38, Zheng Li wrote: >>> >>> On 26/11/2014 15:09, Andrew Cooper wrote: This makes fields 0 and 1 true more often than they should be, re

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-26 Thread Konrad Rzeszutek Wilk
On Wed, Nov 26, 2014 at 08:44:41PM +, Dave Scott wrote: > > > On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk > > wrote: > > > > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: > >> > >>> On 26 Nov 2014, at 15:38, Zheng Li wrote: > >>> > >>> On 26/11/2014 15:09, Andrew Cooper

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-27 Thread Ian Campbell
On Wed, 2014-11-26 at 19:03 +, Andrew Cooper wrote: > On 26/11/14 18:41, Konrad Rzeszutek Wilk wrote: > > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: > >>> On 26 Nov 2014, at 15:38, Zheng Li wrote: > >>> > >>> On 26/11/2014 15:09, Andrew Cooper wrote: > This makes fields 0

Re: [Xen-devel] [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling

2014-11-28 Thread Ian Campbell
On Wed, 2014-11-26 at 16:09 -0500, Konrad Rzeszutek Wilk wrote: > On Wed, Nov 26, 2014 at 08:44:41PM +, Dave Scott wrote: > > > > > On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk > > > wrote: > > > > > > On Wed, Nov 26, 2014 at 06:24:11PM +, Dave Scott wrote: > > >> > > >>> On 26 Nov