Re: [Xen-devel] [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()

2014-12-02 Thread Konrad Rzeszutek Wilk
On Tue, Dec 02, 2014 at 01:50:37PM +, Ian Campbell wrote: On Mon, 2014-12-01 at 16:14 -0500, Konrad Rzeszutek Wilk wrote: On Fri, Nov 28, 2014 at 11:38:52AM +, Ian Campbell wrote: On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: Don't leak a 16k allocation if

Re: [Xen-devel] [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()

2014-12-01 Thread Konrad Rzeszutek Wilk
On Fri, Nov 28, 2014 at 11:38:52AM +, Ian Campbell wrote: On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the first xc_readconsolering() fail. It is trivial to run throught the processes memory by repeatedly

Re: [Xen-devel] [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()

2014-11-28 Thread Ian Campbell
On Thu, 2014-11-27 at 12:34 +, Andrew Cooper wrote: Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the first xc_readconsolering() fail. It is trivial to run throught the processes memory by repeatedly passing junk parameters to this function. In the case that the call

[Xen-devel] [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()

2014-11-27 Thread Andrew Cooper
Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the first xc_readconsolering() fail. It is trivial to run throught the processes memory by repeatedly passing junk parameters to this function. In the case that the call to xc_readconsolering() in the while loop fails, reinstate str