Re: [Xen-devel] [PATCH for-4.7 4/4] x86/hvm: Fix invalidation for emulated invlpg instructions

2016-05-09 Thread Andrew Cooper
On 09/05/16 16:14, Tim Deegan wrote: > Hi, > > At 14:15 +0100 on 09 May (1462803342), Andrew Cooper wrote: >> hap_invlpg() is reachable from the instruction emulator, which means >> introspection and tests using hvm_fep can end up here. As such, crashing the >> domain is not an appropriate action

Re: [Xen-devel] [PATCH for-4.7 4/4] x86/hvm: Fix invalidation for emulated invlpg instructions

2016-05-09 Thread Andrew Cooper
On 09/05/16 14:57, Jan Beulich wrote: On 09.05.16 at 15:15, wrote: >> --- a/xen/arch/x86/hvm/svm/svm.c >> +++ b/xen/arch/x86/hvm/svm/svm.c >> @@ -,10 +,13 @@ static void svm_invlpga_intercept( >> >> static void svm_invlpg_intercept(unsigned long vaddr)

Re: [Xen-devel] [PATCH for-4.7 4/4] x86/hvm: Fix invalidation for emulated invlpg instructions

2016-05-09 Thread Jan Beulich
>>> On 09.05.16 at 15:15, wrote: > --- a/xen/arch/x86/hvm/svm/svm.c > +++ b/xen/arch/x86/hvm/svm/svm.c > @@ -,10 +,13 @@ static void svm_invlpga_intercept( > > static void svm_invlpg_intercept(unsigned long vaddr) > { > -struct vcpu *curr = current; >

[Xen-devel] [PATCH for-4.7 4/4] x86/hvm: Fix invalidation for emulated invlpg instructions

2016-05-09 Thread Andrew Cooper
hap_invlpg() is reachable from the instruction emulator, which means introspection and tests using hvm_fep can end up here. As such, crashing the domain is not an appropriate action to take. Fixing this involves rearranging the callgraph. paging_invlpg() is now the central entry point. It