Re: [Xen-devel] [PATCH for-4.8] libxc: fix unmap of ACPI guest memory region

2016-11-10 Thread Wei Liu
On Tue, Nov 08, 2016 at 05:22:15PM +0100, Roger Pau Monne wrote: > Commit fac7f7 changed the value of ptr so that it points to the right memory > area, taking the page offset into account, but failed to remove this when > doing the unmap, which caused the region to not be unmapped. Fix this by not

Re: [Xen-devel] [PATCH for-4.8] libxc: fix unmap of ACPI guest memory region

2016-11-09 Thread Andrew Cooper
On 08/11/16 16:22, Roger Pau Monne wrote: > Commit fac7f7 changed the value of ptr so that it points to the right memory > area, taking the page offset into account, but failed to remove this when > doing the unmap, which caused the region to not be unmapped. Fix this by not > modifying ptr and ins

Re: [Xen-devel] [PATCH for-4.8] libxc: fix unmap of ACPI guest memory region

2016-11-09 Thread Roger Pau Monne
On Tue, Nov 08, 2016 at 12:19:06PM -0500, Boris Ostrovsky wrote: > > > On 11/08/2016 11:22 AM, Roger Pau Monne wrote: > > Commit fac7f7 changed the value of ptr so that it points to the right memory > > area, taking the page offset into account, but failed to remove this when > > doing the unmap,

Re: [Xen-devel] [PATCH for-4.8] libxc: fix unmap of ACPI guest memory region

2016-11-08 Thread Boris Ostrovsky
On 11/08/2016 11:22 AM, Roger Pau Monne wrote: Commit fac7f7 changed the value of ptr so that it points to the right memory area, taking the page offset into account, but failed to remove this when doing the unmap, which caused the region to not be unmapped. Fix this by not modifying ptr and in

[Xen-devel] [PATCH for-4.8] libxc: fix unmap of ACPI guest memory region

2016-11-08 Thread Roger Pau Monne
Commit fac7f7 changed the value of ptr so that it points to the right memory area, taking the page offset into account, but failed to remove this when doing the unmap, which caused the region to not be unmapped. Fix this by not modifying ptr and instead adding the page offset directly in the memcpy