Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Tian, Kevin
> From: Chen, Tiejun > Sent: Thursday, August 27, 2015 5:05 PM > > On 8/27/2015 4:40 PM, Malcolm Crossley wrote: > > On 27/08/15 03:59, Chen, Tiejun wrote: > >> This kind of issue is already gone. > >> > >> https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html > > > > There is a bug i

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Jan Beulich
>>> On 27.08.15 at 11:05, wrote: > On 8/27/2015 4:40 PM, Malcolm Crossley wrote: >> On 27/08/15 03:59, Chen, Tiejun wrote: >>> This kind of issue is already gone. >>> >>> https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html >> >> There is a bug in the code you refer to above which r

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Jan Beulich
>>> On 26.08.15 at 17:49, wrote: > --- a/xen/drivers/passthrough/vtd/iommu.c > +++ b/xen/drivers/passthrough/vtd/iommu.c > @@ -1839,8 +1839,16 @@ static int rmrr_identity_mapping(struct domain *d, > bool_t map, > > while ( base_pfn < end_pfn ) > { > -if

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Chen, Tiejun
On 8/27/2015 4:40 PM, Malcolm Crossley wrote: On 27/08/15 03:59, Chen, Tiejun wrote: This kind of issue is already gone. https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html There is a bug in the code you refer to above which results in no IOMMU page table mappings being create

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-27 Thread Malcolm Crossley
On 27/08/15 03:59, Chen, Tiejun wrote: > This kind of issue is already gone. > > https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html There is a bug in the code you refer to above which results in no IOMMU page table mappings being created if the guest domain is not sharing it's EP

Re: [Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-26 Thread Chen, Tiejun
This kind of issue is already gone. https://www.mail-archive.com/xen-devel@lists.xen.org/msg32464.html Thanks Tiejun On 8/26/2015 11:49 PM, Malcolm Crossley wrote: Add RMRR 1:1 IOMMU mappings to IOMMU page tables if EPT page table are not being shared with the IOMMU. This is a regression in b

[Xen-devel] [PATCH for 4.6] VT-d: Create IOMMU mappings for RMRR regions if shared EPT is not being used

2015-08-26 Thread Malcolm Crossley
Add RMRR 1:1 IOMMU mappings to IOMMU page tables if EPT page table are not being shared with the IOMMU. This is a regression in behaviour versus Xen 4.5. Signed-off-by: Malcolm Crossley --- xen/drivers/passthrough/vtd/iommu.c | 23 --- 1 file changed, 20 insertions(+), 3 del