Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread Wei Liu
On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote: > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > macro debugging information') exposed a bug whereby the autoconf stuff > in tools was setting its own debug value (defaulting to ENABLED, even > for releases)

Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread Ian Campbell
On Wed, 2015-09-02 at 12:08 +0100, Wei Liu wrote: > On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote: > > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > > macro debugging information') exposed a bug whereby the autoconf stuff > > in tools was setting its own

Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread Wei Liu
On Wed, Sep 02, 2015 at 12:24:31PM +0100, Ian Campbell wrote: > On Wed, 2015-09-02 at 12:08 +0100, Wei Liu wrote: > > On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote: > > > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > > > macro debugging information')

Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread Ian Campbell
On Wed, 2015-09-02 at 10:34 +0100, George Dunlap wrote: > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > macro debugging information') exposed a bug whereby the autoconf stuff > in tools was setting its own debug value (defaulting to ENABLED, even > for releases) instead of

[Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread George Dunlap
Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add macro debugging information') exposed a bug whereby the autoconf stuff in tools was setting its own debug value (defaulting to ENABLED, even for releases) instead of honoring the value set in Config.mk. After that changeset, if

Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread Ian Campbell
On Wed, 2015-09-02 at 12:25 +0100, Wei Liu wrote: > On Wed, Sep 02, 2015 at 12:24:31PM +0100, Ian Campbell wrote: > > On Wed, 2015-09-02 at 12:08 +0100, Wei Liu wrote: > > > On Wed, Sep 02, 2015 at 10:34:55AM +0100, George Dunlap wrote: > > > > Changeset 1166ecf ('tools/Rules.mk: Don't optimize

Re: [Xen-devel] [PATCH for 4.6] tools: Honor Config.mk debug value, rather than setting our own

2015-09-02 Thread George Dunlap
On 09/02/2015 10:34 AM, George Dunlap wrote: > Changeset 1166ecf ('tools/Rules.mk: Don't optimize debug builds; add > macro debugging information') exposed a bug whereby the autoconf stuff > in tools was setting its own debug value (defaulting to ENABLED, even > for releases) instead of honoring