Re: [Xen-devel] [PATCH for 4.9 2/6] x86/hvm: Correct long mode predicate

2017-04-05 Thread Tian, Kevin
> From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: Saturday, April 1, 2017 3:51 AM > > hvm_long_mode_enabled() tests for EFER.LMA, which is specifically different > to > EFER.LME. > > Rename it to match its behaviour, and have it strictly return a boolean value > (although all its c

Re: [Xen-devel] [PATCH for 4.9 2/6] x86/hvm: Correct long mode predicate

2017-04-03 Thread George Dunlap
On 31/03/17 20:50, Andrew Cooper wrote: > hvm_long_mode_enabled() tests for EFER.LMA, which is specifically different to > EFER.LME. > > Rename it to match its behaviour, and have it strictly return a boolean value > (although all its callers already use it in implicitly-boolean contexts, so no >

Re: [Xen-devel] [PATCH for 4.9 2/6] x86/hvm: Correct long mode predicate

2017-04-03 Thread Jan Beulich
>>> On 31.03.17 at 21:50, wrote: > @@ -1154,13 +1154,13 @@ static void virtual_vmentry(struct cpu_user_regs > *regs) > /* > * EFER handling: > * hvm_set_efer won't work if CR0.PG = 1, so we change the value > - * directly to make hvm_long_mode_enabled(v) work in L2. > + *

Re: [Xen-devel] [PATCH for 4.9 2/6] x86/hvm: Correct long mode predicate

2017-04-03 Thread Paul Durrant
> -Original Message- > From: Andrew Cooper [mailto:andrew.coop...@citrix.com] > Sent: 31 March 2017 20:51 > To: Xen-devel > Cc: Andrew Cooper ; Jan Beulich > ; Paul Durrant ; Tim > (Xen.org) ; George Dunlap ; Jun > Nakajima ; Kevin Tian ; > Boris Ostrovsky ; Suravee Suthikulpanit > ; Julie

[Xen-devel] [PATCH for 4.9 2/6] x86/hvm: Correct long mode predicate

2017-03-31 Thread Andrew Cooper
hvm_long_mode_enabled() tests for EFER.LMA, which is specifically different to EFER.LME. Rename it to match its behaviour, and have it strictly return a boolean value (although all its callers already use it in implicitly-boolean contexts, so no functional change). Signed-off-by: Andrew Cooper -