Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-16 Thread Wei Liu
On Thu, Oct 12, 2017 at 12:10:25PM +0300, Alexandru Isaila wrote: > This patch adds the old value param and the onchangeonly option > to the VM_EVENT_REASON_MOV_TO_MSR event. > > The param was added to the vm_event_mov_to_msr struct and to the > hvm_monitor_msr function. Finally I've changed the

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-13 Thread Tamas K Lengyel
On Fri, Oct 13, 2017 at 6:17 AM, Jan Beulich wrote: On 13.10.17 at 12:36, wrote: >> On 13.10.2017 13:29, Jan Beulich wrote: +__set_bit(index + sizeof(struct monitor_msr_bitmap), bitmap); >>> >>> I think you miss "* 8" here - a bit

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-13 Thread Jan Beulich
>>> On 13.10.17 at 12:36, wrote: > On 13.10.2017 13:29, Jan Beulich wrote: >>> +__set_bit(index + sizeof(struct monitor_msr_bitmap), bitmap); >> >> I think you miss "* 8" here - a bit position plus sizeof() doesn't >> produce any useful value. >> >> But what's

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-13 Thread Razvan Cojocaru
On 13.10.2017 13:29, Jan Beulich wrote: +__set_bit(index + sizeof(struct monitor_msr_bitmap), bitmap); I think you miss "* 8" here - a bit position plus sizeof() doesn't produce any useful value. But what's worse - having read till the end of the patch I don't see you change any

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-13 Thread Jan Beulich
>>> On 12.10.17 at 11:10, wrote: > --- a/xen/arch/x86/hvm/monitor.c > +++ b/xen/arch/x86/hvm/monitor.c > @@ -74,16 +74,19 @@ bool hvm_monitor_emul_unimplemented(void) > monitor_traps(curr, true, ) == 1; > } > > -void hvm_monitor_msr(unsigned int msr, uint64_t

Re: [Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-12 Thread Tamas K Lengyel
On Thu, Oct 12, 2017 at 3:10 AM, Alexandru Isaila wrote: > This patch adds the old value param and the onchangeonly option > to the VM_EVENT_REASON_MOV_TO_MSR event. > > The param was added to the vm_event_mov_to_msr struct and to the > hvm_monitor_msr function. Finally

[Xen-devel] [PATCH v1] x86/hvm: Add MSR old value

2017-10-12 Thread Alexandru Isaila
This patch adds the old value param and the onchangeonly option to the VM_EVENT_REASON_MOV_TO_MSR event. The param was added to the vm_event_mov_to_msr struct and to the hvm_monitor_msr function. Finally I've changed the bool_t param to a bool for the hvm_msr_write_intercept function.