Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-08-01 Thread Jan Beulich
>>> On 01.08.16 at 16:06, wrote: > On 08/01/2016 06:09 AM, Jan Beulich wrote: > On 08.07.16 at 18:14, wrote: >>> On 07/08/2016 11:11 AM, Jan Beulich wrote: >>> On 08.07.16 at 16:39, wrote: > On 07/08/2016 06:10 AM, Jan Beulich wrote: >>> @@ -615,20 +593,10 @@ void acpi_build_tabl

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-08-01 Thread Boris Ostrovsky
On 08/01/2016 06:09 AM, Jan Beulich wrote: On 08.07.16 at 18:14, wrote: >> On 07/08/2016 11:11 AM, Jan Beulich wrote: >> On 08.07.16 at 16:39, wrote: On 07/08/2016 06:10 AM, Jan Beulich wrote: >> @@ -615,20 +593,10 @@ void acpi_build_tables(struct acpi_config *config, unsi

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-08-01 Thread Jan Beulich
>>> On 08.07.16 at 18:14, wrote: > On 07/08/2016 11:11 AM, Jan Beulich wrote: > On 08.07.16 at 16:39, wrote: >>> On 07/08/2016 06:10 AM, Jan Beulich wrote: > @@ -615,20 +593,10 @@ void acpi_build_tables(struct acpi_config *config, >>> unsigned int physical) > offset

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 11:38 AM, Ian Jackson wrote: > Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: > Move acpi_info initialization out of ACPI code"): >> But do we need to look at who touched the file or who is explicitly >> listed as copyrig

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Ian Jackson
Ian Jackson writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: > Move acpi_info initialization out of ACPI code"): > > But do we

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > But do we need to look at who touched the file or who is explicitly > listed as copyright holder (in files' headers)? You need to look at the hist

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Boris Ostrovsky
On 07/11/2016 10:54 AM, Konrad Rzeszutek Wilk wrote: > On Mon, Jul 11, 2016 at 03:47:20PM +0100, Lars Kurth wrote: >>> On 11 Jul 2016, at 13:10, Wei Liu wrote: >>> >>> CC Lars >>> >>> More licence stuff. Do you have contact(s)? >> James (on vacation) or I can confirm on behalf of Citrix. >> I am a

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Konrad Rzeszutek Wilk
On Mon, Jul 11, 2016 at 03:47:20PM +0100, Lars Kurth wrote: > > > On 11 Jul 2016, at 13:10, Wei Liu wrote: > > > > CC Lars > > > > More licence stuff. Do you have contact(s)? > > James (on vacation) or I can confirm on behalf of Citrix. > I am assuming that Konrad can get the approval for Sun/

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Lars Kurth
> On 11 Jul 2016, at 13:10, Wei Liu wrote: > > CC Lars > > More licence stuff. Do you have contact(s)? James (on vacation) or I can confirm on behalf of Citrix. I am assuming that Konrad can get the approval for Sun/Oracle As for Intel, we can ask Susie Li. It would have to be a Intel decision

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-11 Thread Wei Liu
CC Lars More licence stuff. Do you have contact(s)? Wei. On Fri, Jul 08, 2016 at 11:57:59AM -0400, Boris Ostrovsky wrote: > On 07/08/2016 11:50 AM, Ian Jackson wrote: > > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH v1 02/20] > > acpi/hvmloader: Move acpi_info i

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Ian Jackson
Boris Ostrovsky writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > Do we need to get consent from companies only or (also) from individuals > listed in the files? Which means Keir and Kamala Narasimhan (who works, >

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Boris Ostrovsky
On 07/08/2016 11:11 AM, Jan Beulich wrote: On 08.07.16 at 16:39, wrote: >> On 07/08/2016 06:10 AM, Jan Beulich wrote: @@ -615,20 +593,10 @@ void acpi_build_tables(struct acpi_config *config, >> unsigned int physical) offsetof(struct acpi_20_rsdp, extended_checksum

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Boris Ostrovsky
On 07/08/2016 11:50 AM, Ian Jackson wrote: > Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH v1 02/20] > acpi/hvmloader: Move acpi_info initialization out of ACPI code"): >> Having different licenses will invite the lawyers in the conversation >> which can drag

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Ian Jackson
Konrad Rzeszutek Wilk writes ("Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > Having different licenses will invite the lawyers in the conversation > which can drag things out. We don't want libxl to have some confusing c

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Jan Beulich
>>> On 08.07.16 at 16:39, wrote: > On 07/08/2016 06:10 AM, Jan Beulich wrote: >> >>> @@ -615,20 +593,10 @@ void acpi_build_tables(struct acpi_config *config, > unsigned int physical) >>> offsetof(struct acpi_20_rsdp, extended_checksum), >>> sizeof(struct acpi_2

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Konrad Rzeszutek Wilk
On Thu, Jul 07, 2016 at 01:45:05PM -0400, Boris Ostrovsky wrote: > On 07/07/2016 01:15 PM, Wei Liu wrote: > > On Thu, Jul 07, 2016 at 01:09:28PM -0400, Boris Ostrovsky wrote: > >> On 07/07/2016 12:58 PM, Ian Jackson wrote: > >>> There are two serious problems with this. > >>> > >>> 1. You have drop

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Boris Ostrovsky
On 07/08/2016 06:10 AM, Jan Beulich wrote: > >> @@ -615,20 +593,10 @@ void acpi_build_tables(struct acpi_config *config, >> unsigned int physical) >> offsetof(struct acpi_20_rsdp, extended_checksum), >> sizeof(struct acpi_20_rsdp)); >> >> -if ( !new_vm_gid

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-08 Thread Jan Beulich
>>> On 05.07.16 at 21:05, wrote: > --- a/tools/firmware/hvmloader/acpi/acpi2_0.h > +++ b/tools/firmware/hvmloader/acpi/acpi2_0.h > @@ -449,17 +449,6 @@ struct acpi_20_slit { > #define ACPI_2_0_SRAT_REVISION 0x01 > #define ACPI_2_0_SLIT_REVISION 0x01 > > -#pragma pack () This must not be remov

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-07 Thread Boris Ostrovsky
On 07/07/2016 01:15 PM, Wei Liu wrote: > On Thu, Jul 07, 2016 at 01:09:28PM -0400, Boris Ostrovsky wrote: >> On 07/07/2016 12:58 PM, Ian Jackson wrote: >>> There are two serious problems with this. >>> >>> 1. You have dropped the copyright attribution to Intel and Xensource. >>> >>> 2. You have cha

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-07 Thread Wei Liu
On Thu, Jul 07, 2016 at 01:09:28PM -0400, Boris Ostrovsky wrote: > On 07/07/2016 12:58 PM, Ian Jackson wrote: > > > > There are two serious problems with this. > > > > 1. You have dropped the copyright attribution to Intel and Xensource. > > > > 2. You have changed the licence to BSD-style, even th

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-07 Thread Boris Ostrovsky
On 07/07/2016 12:58 PM, Ian Jackson wrote: > > There are two serious problems with this. > > 1. You have dropped the copyright attribution to Intel and Xensource. > > 2. You have changed the licence to BSD-style, even though the original >was GPLv2-only. I meant this to be a GPLv2 license. An

Re: [Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-07 Thread Ian Jackson
Boris Ostrovsky writes ("[PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code"): > acpi_info can be initialized by hvmloader itself. Now ACPI code > doesn't need to use hvmloader-private variables/routines such as > uart_exists(), lpt_exists() etc. ... > Signed-off-by: B

[Xen-devel] [PATCH v1 02/20] acpi/hvmloader: Move acpi_info initialization out of ACPI code

2016-07-05 Thread Boris Ostrovsky
acpi_info can be initialized by hvmloader itself. Now ACPI code doesn't need to use hvmloader-private variables/routines such as uart_exists(), lpt_exists() etc. Signed-off-by: Boris Ostrovsky --- Changes in v1: * Create libacpi.h for libacpi interface definitions * Move RSDP struct acpi_info poi