Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-29 Thread Jan Beulich
>>> On 28.10.15 at 19:34, wrote: > On 28/10/15 17:55, Konrad Rzeszutek Wilk wrote: >> On Fri, Oct 09, 2015 at 08:38:34AM -0600, Jan Beulich wrote: >> On 09.10.15 at 14:46, wrote: On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: > On 09/10/15 09:25, Jan Beulich wrote: >

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-28 Thread Konrad Rzeszutek Wilk
On Wed, Oct 28, 2015 at 06:34:37PM +, Andrew Cooper wrote: > On 28/10/15 17:55, Konrad Rzeszutek Wilk wrote: > > On Fri, Oct 09, 2015 at 08:38:34AM -0600, Jan Beulich wrote: > > On 09.10.15 at 14:46, wrote: > >>> On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: > On 09/10/15 09

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-28 Thread Andrew Cooper
On 28/10/15 17:55, Konrad Rzeszutek Wilk wrote: > On Fri, Oct 09, 2015 at 08:38:34AM -0600, Jan Beulich wrote: > On 09.10.15 at 14:46, wrote: >>> On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: On 09/10/15 09:25, Jan Beulich wrote: On 09.10.15 at 04:56, wrote: >> All

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-28 Thread Konrad Rzeszutek Wilk
On Fri, Oct 09, 2015 at 08:38:34AM -0600, Jan Beulich wrote: > >>> On 09.10.15 at 14:46, wrote: > > On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: > >> On 09/10/15 09:25, Jan Beulich wrote: > >> > > > > On 09.10.15 at 04:56, wrote: > >> > > All existing commands ignore the parameter so t

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Ian Campbell
On Fri, 2015-10-09 at 08:38 -0600, Jan Beulich wrote: > > > > On 09.10.15 at 14:46, wrote: > > On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: > > > On 09/10/15 09:25, Jan Beulich wrote: > > > > > > > On 09.10.15 at 04:56, wrote: > > > > > All existing commands ignore the parameter so thi

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Jan Beulich
>>> On 09.10.15 at 14:46, wrote: > On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: >> On 09/10/15 09:25, Jan Beulich wrote: >> > > > > On 09.10.15 at 04:56, wrote: >> > > All existing commands ignore the parameter so this does >> > > not break the ABI. >> > Does it not? What about the deb

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Andrew Cooper
On 09/10/15 13:46, Ian Campbell wrote: > On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: >> On 09/10/15 09:25, Jan Beulich wrote: >> On 09.10.15 at 04:56, wrote: All existing commands ignore the parameter so this does not break the ABI. >>> Does it not? What about the debug m

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Ian Campbell
On Fri, 2015-10-09 at 13:29 +0100, Andrew Cooper wrote: > On 09/10/15 09:25, Jan Beulich wrote: > > > > > On 09.10.15 at 04:56, wrote: > > > All existing commands ignore the parameter so this does > > > not break the ABI. > > Does it not? What about the debug mode clobbering of hypercall > > argum

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Andrew Cooper
On 09/10/15 09:25, Jan Beulich wrote: On 09.10.15 at 04:56, wrote: >> All existing commands ignore the parameter so this does >> not break the ABI. > Does it not? What about the debug mode clobbering of hypercall > argument registers? That is an implementation detail of the hypervisor. It i

Re: [Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-09 Thread Jan Beulich
>>> On 09.10.15 at 04:56, wrote: > All existing commands ignore the parameter so this does > not break the ABI. Does it not? What about the debug mode clobbering of hypercall argument registers? I think such length indicators need to be part of the newly added sub-structures instead. > This pave

[Xen-devel] [PATCH v1 2/4] xen-version: Add third parameter (len) to the do_version hypercall.

2015-10-08 Thread Konrad Rzeszutek Wilk
All existing commands ignore the parameter so this does not break the ABI. This paves the way for expanding the XENVER_ hypercall with variable size structures, such as "XENVER_build_id: Provide ld-embedded build-ids" Suggested-by: Andrew Cooper Signed-off-by: Konrad Rzeszutek Wilk --- xen/arch