Re: [Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-16 Thread Krish Sadhukhan
Acknowledging it formally... Reviewed-by: Krish Sadhukhan The review was based on Intel SDM chapters 24 and 30. -Krish On 03/16/2017 11:24 AM, Krish Sadhukhan wrote: This one looks good to me. -Krish On 03/13/2017 03:51 AM, Sergey Dyasli wrote: Intel SDM states that if the current VMCS is

Re: [Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-16 Thread Krish Sadhukhan
This one looks good to me. -Krish On 03/13/2017 03:51 AM, Sergey Dyasli wrote: Intel SDM states that if the current VMCS is a shadow VMCS, VMFailInvalid occurs and control passes to the next instruction. Implement such behaviour for nested vmlaunch. Signed-off-by: Sergey Dyasli --- xen/arc

Re: [Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-14 Thread Tian, Kevin
> From: Sergey Dyasli [mailto:sergey.dya...@citrix.com] > Sent: Monday, March 13, 2017 6:52 PM > > Intel SDM states that if the current VMCS is a shadow VMCS, VMFailInvalid > occurs and control passes to the next instruction. > > Implement such behaviour for nested vmlaunch. > > Signed-off-by: S

[Xen-devel] [PATCH v1 3/3] x86/vvmx: add a shadow vmcs check to vmlaunch

2017-03-13 Thread Sergey Dyasli
Intel SDM states that if the current VMCS is a shadow VMCS, VMFailInvalid occurs and control passes to the next instruction. Implement such behaviour for nested vmlaunch. Signed-off-by: Sergey Dyasli --- xen/arch/x86/hvm/vmx/vvmx.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/xen/