Re: [Xen-devel] [PATCH v1 4/7] page-alloc: Remove dependency on __LINE__ for release builds

2016-05-10 Thread Andrew Cooper
On 06/05/16 16:48, Ross Lagerwall wrote: > When using xsplice, use of __LINE__ can generate spurious changes in > functions due to embedded line numbers. For release builds, remove the > use of these line numbers in BOOT_BUG_ON() and print the current text > address instead. > > Signed-off-by: Ros

Re: [Xen-devel] [PATCH v1 4/7] page-alloc: Remove dependency on __LINE__ for release builds

2016-05-10 Thread Jan Beulich
>>> On 06.05.16 at 17:48, wrote: > --- a/xen/common/page_alloc.c > +++ b/xen/common/page_alloc.c > @@ -206,11 +206,19 @@ struct scrub_region { > static struct scrub_region __initdata region[MAX_NUMNODES]; > static unsigned long __initdata chunk_size; > > +#ifdef NDEBUG > +static void __init bo

[Xen-devel] [PATCH v1 4/7] page-alloc: Remove dependency on __LINE__ for release builds

2016-05-06 Thread Ross Lagerwall
When using xsplice, use of __LINE__ can generate spurious changes in functions due to embedded line numbers. For release builds, remove the use of these line numbers in BOOT_BUG_ON() and print the current text address instead. Signed-off-by: Ross Lagerwall --- xen/common/page_alloc.c | 8 ++