Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

> > > @@ -24,7 +27,9 @@ const char *xen_hello_world(void) > > > */ > > > rc = __get_user(tmp, non_canonical_addr); > > > BUG_ON(rc != -EFAULT); > > > - > > > +#else > > > + asm(ALTERNATIVE("nop", "nop", 1)); > > > > Why the hardcoded 1 here? I am wondering if we should

Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

> > > > +#else > > > > + asm(ALTERNATIVE("nop", "nop", 1)); > > > > > > Why the hardcoded 1 here? I am wondering if we should introduce a new > > > capability "LIVEPATCH_TEST" which is enabled by default. So we can test > > > that > > > the the alternative is working on all the platform.

Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

>>> On 17.08.16 at 22:08, wrote: > On 17/08/2016 20:57, Julien Grall wrote: >> Hi Konrad, >> >> On 17/08/2016 20:00, Konrad Rzeszutek Wilk wrote: >>> On Wed, Aug 17, 2016 at 07:29:12PM +0100, Julien Grall wrote: On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: >> >>

Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

On 17/08/2016 20:57, Julien Grall wrote: > Hi Konrad, > > On 17/08/2016 20:00, Konrad Rzeszutek Wilk wrote: >> On Wed, Aug 17, 2016 at 07:29:12PM +0100, Julien Grall wrote: >>> On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: > > [...] > diff --git a/xen/common/Makefile b/xen/common/Makefile

Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

Hi Konrad, On 17/08/2016 20:00, Konrad Rzeszutek Wilk wrote: On Wed, Aug 17, 2016 at 07:29:12PM +0100, Julien Grall wrote: On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: [...] diff --git a/xen/common/Makefile b/xen/common/Makefile index 22806b6..fe83653 100644 --- a/xen/common/Makefile

Re: [Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

On Wed, Aug 17, 2016 at 07:29:12PM +0100, Julien Grall wrote: > Hi Konrad, > > On 15/08/16 00:07, Konrad Rzeszutek Wilk wrote: > > We need to two things: > > 1) Wrap the platform-specific objcopy paramters in defines > > s/paramters/parameters/ > > >The input and output parmeters for

[Xen-devel] [PATCH v1 9/9] livepatch: tests: Make them compile under ARM64

We need to two things: 1) Wrap the platform-specific objcopy paramters in defines The input and output parmeters for $(OBJCOPY) are different based on the platforms. As such provide them in the OBJCOPY_MAGIC define and use that. 2) The alternative is a bit different and there are no