Re: [Xen-devel] [PATCH v10 04/24] xen-xsplice: Tool to manipulate xsplice payloads

2016-05-01 Thread Konrad Rzeszutek Wilk
> > +/* The memset is done to catch errors. */ > > +memset(info, 'A', sizeof(*info) * MAX_LEN); > > +memset(name, 'B', sizeof(*name * MAX_LEN * XEN_XSPLICE_NAME_SIZE)); > > Did you mean to put the "* MAX_LEN * XEN_XSPLICE_NAME_SIZE" inside the > sizeof()? Coverity thinks

Re: [Xen-devel] [PATCH v10 04/24] xen-xsplice: Tool to manipulate xsplice payloads

2016-05-01 Thread Wei Liu
On Sun, May 01, 2016 at 02:34:18PM +0100, George Dunlap wrote: [...] > > +name = malloc(sizeof(*name) * XEN_XSPLICE_NAME_SIZE * MAX_LEN); [...] > > +/* The memset is done to catch errors. */ > > +memset(info, 'A', sizeof(*info) * MAX_LEN); > > +memset(name, 'B',

Re: [Xen-devel] [PATCH v10 04/24] xen-xsplice: Tool to manipulate xsplice payloads

2016-05-01 Thread George Dunlap
On Wed, Apr 27, 2016 at 8:27 PM, Konrad Rzeszutek Wilk wrote: > A simple tool that allows an system admin to perform > basic xsplice operations: > > - Upload a xsplice file (with an unique name) > - List all the xsplice payloads loaded. > - Apply, revert, replace, or

[Xen-devel] [PATCH v10 04/24] xen-xsplice: Tool to manipulate xsplice payloads

2016-04-27 Thread Konrad Rzeszutek Wilk
A simple tool that allows an system admin to perform basic xsplice operations: - Upload a xsplice file (with an unique name) - List all the xsplice payloads loaded. - Apply, revert, replace, or unload the payload using the unique name. - Do all two - upload, and apply the payload in one go