Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-22 Thread Dario Faggioli
On Fri, 2016-03-18 at 01:45 -0600, Jan Beulich wrote: > >  > > > > On 18.03.16 at 05:09, wrote: > > Great job! However, we still have 1 mile in the 100-mile journey. > > :-D > > > > I applied the patch on staging and tried some test cases. One of > > them > > is as follows: > > > > I tried to cr

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Dario Faggioli
On Fri, 2016-03-18 at 00:09 -0400, Meng Xu wrote: > The test scenario is: > Pool-0 has rtds scheduler, > then I create  cpupools with credit, credit2, rtds scheduler; The bug > occurs when I run the scripts. However, my machine just got stuck and > never goes up.. :-( > What's worse, the remote pow

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Meng Xu
Hi Tianyang, Great job! However, we still have 1 mile in the 100-mile journey. :-D I applied the patch on staging and tried some test cases. One of them is as follows: I tried to create a cpupool and then migrate a VM to the new cpupool; However, the system triggers the bug as below. I guess thi

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Meng Xu
> >> If I can already point you to something else that can be improved >> further in this scheduler, _completely_ independently from this, and >> hence in a fully new patch (series), can you have a look at whether we >> really need set_bit(), test_and_clear(), etc, instead of __set_bit(), >> __test

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Meng Xu
>> > I tried to create a cpupool and then migrate a VM to the new >> > cpupool; >> > BTW, Meng: > > (XEN)[] schedule_cpu_switch+0x250/0x28a > (XEN)[] cpupool.c#cpupool_assign_cpu_locked+0x31/0x11f > > I think you mean "and then move a CPU from a cpupool to another". Or > perhaps what you sa

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Dario Faggioli
On Thu, 2016-03-17 at 12:06 -0400, Tianyang Chen wrote: > The current RTDS code has several problems: >  - the scheduler, although the algorithm is event driven by >    nature, follows a time driven model (is invoked periodically!), >    making the code look unnatural; >  - budget replenishment log

[Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Tianyang Chen
The current RTDS code has several problems: - the scheduler, although the algorithm is event driven by nature, follows a time driven model (is invoked periodically!), making the code look unnatural; - budget replenishment logic, budget enforcement logic and scheduling decisions are mixed

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Jan Beulich
>>> On 18.03.16 at 05:09, wrote: > Great job! However, we still have 1 mile in the 100-mile journey. :-D > > I applied the patch on staging and tried some test cases. One of them > is as follows: > > I tried to create a cpupool and then migrate a VM to the new cpupool; > However, the system trig

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-19 Thread Chen, Tianyang
On 03/17/2016 02:27 PM, Dario Faggioli wrote: Finally, when waking up a vcpu, it is now enough to tickle the various CPUs appropriately, like all other schedulers also do. Signed-off-by: Tianyang Chen Signed-off-by: Meng Xu Signed-off-by: Dagaen Golomb You seem to have taken care of all m

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-18 Thread Meng Xu
On Fri, Mar 18, 2016 at 3:45 AM, Jan Beulich wrote: On 18.03.16 at 05:09, wrote: >> Great job! However, we still have 1 mile in the 100-mile journey. :-D >> >> I applied the patch on staging and tried some test cases. One of them >> is as follows: >> >> I tried to create a cpupool and then m

Re: [Xen-devel] [PATCH v11]xen: sched: convert RTDS from time to event driven model

2016-03-18 Thread Meng Xu
On Thu, Mar 17, 2016 at 12:06 PM, Tianyang Chen wrote: > The current RTDS code has several problems: > - the scheduler, although the algorithm is event driven by >nature, follows a time driven model (is invoked periodically!), >making the code look unnatural; > - budget replenishment log