Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-10 Thread Peter Zijlstra
On Tue, Nov 10, 2015 at 11:27:33AM +, Stefano Stabellini wrote: > On Mon, 9 Nov 2015, Peter Zijlstra wrote: > > On Thu, Nov 05, 2015 at 05:30:01PM +, Stefano Stabellini wrote: > > > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > > > How can this be missing? Things compile fine now, right? >

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-10 Thread Stefano Stabellini
On Mon, 9 Nov 2015, Peter Zijlstra wrote: > On Thu, Nov 05, 2015 at 05:30:01PM +, Stefano Stabellini wrote: > > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > > How can this be missing? Things compile fine now, right? > > > > Fair enough. > > > > > > > So please better explain why we do this cha

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-09 Thread Peter Zijlstra
On Thu, Nov 05, 2015 at 05:30:01PM +, Stefano Stabellini wrote: > On Thu, 5 Nov 2015, Peter Zijlstra wrote: > > How can this be missing? Things compile fine now, right? > > Fair enough. > > > > So please better explain why we do this change. > > asm/paravirt.h is included by one of the othe

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-05 Thread Stefano Stabellini
On Thu, 5 Nov 2015, Peter Zijlstra wrote: > How can this be missing? Things compile fine now, right? Fair enough. > So please better explain why we do this change. asm/paravirt.h is included by one of the other headers included in kernel/sched/cputime.c on x86, but not on other architecures. On

Re: [Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-05 Thread Peter Zijlstra
How can this be missing? Things compile fine now, right? So please better explain why we do this change. ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel

[Xen-devel] [PATCH v11 2/5] missing include asm/paravirt.h in cputime.c

2015-11-05 Thread Stefano Stabellini
Add include asm/paravirt.h to cputime.c, as steal_account_process_tick calls paravirt_steal_clock, which is defined in asm/paravirt.h. The ifdef CONFIG_PARAVIRT is necessary because not all archs have an asm/paravirt.h to include. Signed-off-by: Stefano Stabellini CC: mi...@redhat.com CC: pet...