Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-31 Thread Jan Beulich
>>> On 31.01.17 at 15:23, wrote: > On Tue, Jan 31, 2017 at 05:33:12AM -0700, Jan Beulich wrote: >> >>> On 25.01.17 at 23:49, wrote: >> > On Wed, Jan 25, 2017 at 04:20:30PM -0600, Doug Goldstein wrote: >> > @@ -123,6 +116,15 @@ efi_platform: >> > .Lbad_ldr_nih: .asciz "ERR: EFI ImageHandle is not

Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-31 Thread Daniel Kiper
On Tue, Jan 31, 2017 at 05:33:12AM -0700, Jan Beulich wrote: > >>> On 25.01.17 at 23:49, wrote: > > On Wed, Jan 25, 2017 at 04:20:30PM -0600, Doug Goldstein wrote: > >> This is a huge change and would really be helpful to have the diff of > >> what's changed to work from. > > > > Please look below

Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-31 Thread Jan Beulich
>>> On 25.01.17 at 23:49, wrote: > On Wed, Jan 25, 2017 at 04:20:30PM -0600, Doug Goldstein wrote: >> This is a huge change and would really be helpful to have the diff of >> what's changed to work from. > > Please look below... Thanks for providing this - I'll comment this rather than the full

Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-25 Thread Daniel Kiper
On Wed, Jan 25, 2017 at 04:20:30PM -0600, Doug Goldstein wrote: > On 1/25/17 4:11 PM, Daniel Kiper wrote: > > This way Xen can be loaded on EFI platforms using GRUB2 and > > other boot loaders which support multiboot2 protocol. > > > > Signed-off-by: Daniel Kiper > > --- > > v13 - suggestions/fix

Re: [Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-25 Thread Doug Goldstein
On 1/25/17 4:11 PM, Daniel Kiper wrote: > This way Xen can be loaded on EFI platforms using GRUB2 and > other boot loaders which support multiboot2 protocol. > > Signed-off-by: Daniel Kiper > --- > v13 - suggestions/fixes: > - move vga_text_buffer and efi_platform to .init.data section >

[Xen-devel] [PATCH v13 4/9] x86: add multiboot2 protocol support for EFI platforms

2017-01-25 Thread Daniel Kiper
This way Xen can be loaded on EFI platforms using GRUB2 and other boot loaders which support multiboot2 protocol. Signed-off-by: Daniel Kiper --- v13 - suggestions/fixes: - move vga_text_buffer and efi_platform to .init.data section (suggested by Jan Beulich), - reduce number of err