Re: [Xen-devel] [PATCH v2] VT-d: correct a comment and remove an useless if() statement

2017-04-13 Thread Julien Grall
Hi Jan, On 12/04/17 13:44, Jan Beulich wrote: On 12.04.17 at 07:35, wrote: Fix two flaws in the patch (93358e8e VT-d: introduce update_irte to update irte safely): 1. Expand a comment in update_irte() to make it clear that VT-d hardware doesn't update IRTE and software can't update IRTE behind

Re: [Xen-devel] [PATCH v2] VT-d: correct a comment and remove an useless if() statement

2017-04-12 Thread Tian, Kevin
> From: Gao, Chao > Sent: Wednesday, April 12, 2017 1:35 PM > > Fix two flaws in the patch (93358e8e VT-d: introduce update_irte to update > irte safely): > 1. Expand a comment in update_irte() to make it clear that VT-d hardware > doesn't update IRTE and software can't update IRTE behind us since

Re: [Xen-devel] [PATCH v2] VT-d: correct a comment and remove an useless if() statement

2017-04-12 Thread Jan Beulich
>>> On 12.04.17 at 07:35, wrote: > Fix two flaws in the patch (93358e8e VT-d: introduce update_irte to update > irte safely): > 1. Expand a comment in update_irte() to make it clear that VT-d hardware > doesn't update IRTE and software can't update IRTE behind us since we hold > iremap_lock. > 2.

[Xen-devel] [PATCH v2] VT-d: correct a comment and remove an useless if() statement

2017-04-12 Thread Chao Gao
Fix two flaws in the patch (93358e8e VT-d: introduce update_irte to update irte safely): 1. Expand a comment in update_irte() to make it clear that VT-d hardware doesn't update IRTE and software can't update IRTE behind us since we hold iremap_lock. 2. remove an useless if() statement Signed-off-b